Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix push API to respect feature view's already inferred entity types #3172

Merged
merged 3 commits into from
Sep 7, 2022

Conversation

adchia
Copy link
Collaborator

@adchia adchia commented Sep 3, 2022

This issue showed up with pushing to the online store using Snowflake as an offline store. The bug being:

1001 in Snowflake is an Int64. In pandas, it is an Int32. Feast stores inferred entity types in the feature view, not the entity, and so this was causing the Snowflake quickstart's push call to not know that 1001 should be an int64, so it never coerces it. This resulted in it looking like push calls never impacted the online store

This also updates the roadmap

Signed-off-by: Danny Chiao danny@tecton.ai

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #3171

…ypes

Signed-off-by: Danny Chiao <danny@tecton.ai>
Signed-off-by: Danny Chiao <danny@tecton.ai>
@feast-ci-bot feast-ci-bot added size/M and removed size/S labels Sep 3, 2022
Signed-off-by: Danny Chiao <danny@tecton.ai>
@codecov-commenter
Copy link

codecov-commenter commented Sep 3, 2022

Codecov Report

Base: 67.03% // Head: 76.18% // Increases project coverage by +9.15% 🎉

Coverage data is based on head (9ff2794) compared to base (b4ef834).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3172      +/-   ##
==========================================
+ Coverage   67.03%   76.18%   +9.15%     
==========================================
  Files         175      211      +36     
  Lines       15941    17889    +1948     
==========================================
+ Hits        10686    13629    +2943     
+ Misses       5255     4260     -995     
Flag Coverage Δ
integrationtests 66.86% <100.00%> (-0.18%) ⬇️
unittests 58.36% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdk/python/feast/infra/provider.py 77.94% <ø> (ø)
sdk/python/feast/feature_store.py 85.55% <100.00%> (+3.48%) ⬆️
sdk/python/feast/infra/passthrough_provider.py 96.29% <100.00%> (ø)
...on/feast/infra/materialization/snowflake_engine.py 92.13% <0.00%> (-0.46%) ⬇️
...line_stores/contrib/athena_offline_store/athena.py 38.50% <0.00%> (ø)
.../online_stores/contrib/hbase_online_store/hbase.py 37.25% <0.00%> (ø)
...ores/contrib/trino_offline_store/tests/__init__.py 100.00% <0.00%> (ø)
...ine_stores/contrib/cassandra_repo_configuration.py 100.00% <0.00%> (ø)
.../contrib/postgres_offline_store/postgres_source.py 50.66% <0.00%> (ø)
...offline_stores/contrib/mssql_repo_configuration.py 100.00% <0.00%> (ø)
... and 103 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@felixwang9817 felixwang9817 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch! should we add a test for this?

@sfc-gh-madkins
Copy link
Collaborator

Verified on snowflake template

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adchia, kevjumba

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@achals
Copy link
Member

achals commented Sep 7, 2022

/lgtm

@feast-ci-bot feast-ci-bot merged commit 7c50ab5 into feast-dev:master Sep 7, 2022
adchia added a commit that referenced this pull request Sep 8, 2022
…ypes (#3172)

* fix: Fix push API to respect feature view's already inferred entity types

Signed-off-by: Danny Chiao <danny@tecton.ai>

* fix roadmap

Signed-off-by: Danny Chiao <danny@tecton.ai>

* fix helm

Signed-off-by: Danny Chiao <danny@tecton.ai>

Signed-off-by: Danny Chiao <danny@tecton.ai>
adchia pushed a commit that referenced this pull request Sep 8, 2022
## [0.24.1](v0.24.0...v0.24.1) (2022-09-08)

### Bug Fixes

* Fix push API to respect feature view's already inferred entity types ([#3172](#3172)) ([5dba4a3](5dba4a3))
* Fix release workflow ([#3144](#3144)) ([c77a655](c77a655))
* Fix Shopify timestamp bug and add warnings to help with debugging entity registration ([#3191](#3191)) ([95066ea](95066ea))
* Handle complex Spark data types in SparkSource ([#3154](#3154)) ([0e13573](0e13573))
felixwang9817 pushed a commit that referenced this pull request Sep 20, 2022
# [0.25.0](v0.24.0...v0.25.0) (2022-09-20)

### Bug Fixes

* Broken Feature Service Link ([#3227](#3227)) ([e117082](e117082))
* Feature-server image is missing mysql dependency for mysql registry ([#3223](#3223)) ([ae37b20](ae37b20))
* Fix handling of TTL in Go server ([#3232](#3232)) ([f020630](f020630))
* Fix materialization when running on Spark cluster. ([#3166](#3166)) ([175fd25](175fd25))
* Fix push API to respect feature view's already inferred entity types ([#3172](#3172)) ([7c50ab5](7c50ab5))
* Fix release workflow ([#3144](#3144)) ([20a9dd9](20a9dd9))
* Fix Shopify timestamp bug and add warnings to help with debugging entity registration ([#3191](#3191)) ([de75971](de75971))
* Handle complex Spark data types in SparkSource ([#3154](#3154)) ([5ddb83b](5ddb83b))
* Local staging location provision ([#3195](#3195)) ([cdf0faf](cdf0faf))
* Remove bad snowflake offline store method ([#3204](#3204)) ([dfdd0ca](dfdd0ca))
* Remove opening file object when validating S3 parquet source ([#3217](#3217)) ([a906018](a906018))
* Snowflake config file search error ([#3193](#3193)) ([189afb9](189afb9))
* Update Snowflake Online docs ([#3206](#3206)) ([7bc1dff](7bc1dff))

### Features

* Add `to_remote_storage` functionality to `SparkOfflineStore` ([#3175](#3175)) ([2107ce2](2107ce2))
* Add ability to give boto extra args for registry config ([#3219](#3219)) ([fbc6a2c](fbc6a2c))
* Add health endpoint to py server ([#3202](#3202)) ([43222f2](43222f2))
* Add snowflake support for date & number with scale ([#3148](#3148)) ([50e8755](50e8755))
* Add tag kwarg to set Snowflake online store table path ([#3176](#3176)) ([39aeea3](39aeea3))
* Add workgroup to athena offline store config ([#3139](#3139)) ([a752211](a752211))
* Implement spark materialization engine ([#3184](#3184)) ([a59c33a](a59c33a))
@adchia adchia deleted the fixPush branch May 9, 2023 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Entity data type (int32) do not match PushSource data type (int64) when pushing to online store
7 participants