Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

i think temporaryfile needs to closed before they are removed. I am running into permission error. #3

Closed
karthiek opened this issue Feb 16, 2018 · 2 comments
Closed

i think temporaryfile needs to closed before they are removed. I am running into permission error. #3

karthiek opened this issue Feb 16, 2018 · 2 comments

Comments

@karthiek
Copy link

karthiek commented Feb 16, 2018 •
edited
Loading

Hi

I am getting permission error at
os.remove(tmps[tmp_id].name) because this temporary file is used by a different application.

Added this line
tmps[tmp_id].close()
just before
os.remove(tmps[tmp_id].name) #line 124
in read.py
to resolve the issue.
@faroit
Copy link
Owner

faroit commented Feb 17, 2018 •
edited
Loading

Hi, yes you are right. Thanks for spotting this.
Feel free to create a pull request for this to fix it.

faroit pushed a commit that referenced this issue Feb 18, 2018
close file before removing it, addressing issue #3
db56cb6
@faroit
Copy link
Owner

faroit commented Feb 18, 2018

fixed in db56cb6. Also I made a new release. Thanks again.

@faroit faroit closed this as completed Feb 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@faroit @karthiek