Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add source tarball artifact to releases #900

Open
fredemmott opened this issue Apr 1, 2021 · 1 comment
Open

Add source tarball artifact to releases #900

fredemmott opened this issue Apr 1, 2021 · 1 comment

Comments

@fredemmott
Copy link
Contributor

GitHub's automatically generated tarballs occasionally change; this makes them unsuitable for pinning as a dependency, as hashes etc can't be used to verify that we're getting what we expect.

This blocks adding watchman as a build-dependency of hhvm

@fredemmott fredemmott changed the title Add sourced tarball artifact to releases Add source tarball artifact to releases Apr 1, 2021
@fredemmott
Copy link
Contributor Author

Eh, it's not a blocker, just very nice to have: it happens rarely enough that we can temporarily use github's generated tarballs (which AIUI change whenever git archive's behavior changes).

If they change before this is fixed, we'll have to cherrypick new checksums to 8 hhvm release branches, but that's not a blocking amount of effort

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant