Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

epid is used on systems where LOCAL_PEERCRED isn't defined #842

Open
yurivict opened this issue Aug 11, 2020 · 2 comments
Open

epid is used on systems where LOCAL_PEERCRED isn't defined #842

yurivict opened this issue Aug 11, 2020 · 2 comments

Comments

@yurivict
Copy link
Contributor

Here https://github.com/facebook/watchman/blob/master/stream_unix.cpp#L105 epid is only defined when LOCAL_PEERCRED is defined.

But here https://github.com/facebook/watchman/blob/master/stream_unix.cpp#L133 they are both used unconditionally.
@wez
Copy link
Contributor

wez commented Aug 12, 2020

Of the systems that we support, (Linux, macOS, Windows), this is fine.
Is this causing a problem in practice?

@yurivict
Copy link
Contributor Author

It fails to build on FreeBSD because this undefined field is used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wez @yurivict