Fix DB::Open() error logging #9784
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Right now we log a wrong error when DB::Open() fails. Fix it. Test Plan: CI runs should pass
|
@siying has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
riversand963
approved these changes
Mar 31, 2022
ajkr
approved these changes
Mar 31, 2022
| ROCKS_LOG_WARN(impl->immutable_db_options_.info_log, | ||
| "Persisting Option File error: %s", |
There was a problem hiding this comment.
ugh, I've seen "Persisting Option File error: OK" warning and been confused so many times. I should've fixed it a long time ago...
ajkr
pushed a commit
that referenced
this pull request
Apr 18, 2022
Summary: Right now we log a wrong error when DB::Open() fails. Fix it. Pull Request resolved: #9784 Test Plan: CI runs should pass Reviewed By: ajkr, riversand963 Differential Revision: D35290203 fbshipit-source-id: ffc640afa27f6b0a2382ee153dc43f28d9e242be
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Right now we log a wrong error when DB::Open() fails. Fix it.
Test Plan: CI runs should pass