-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RFC] Move RADOS support to separate repo #9206
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PLUGINS.md
Outdated
@@ -2,3 +2,4 @@ This is the list of all known third-party plugins for RocksDB. If something is m | |||
|
|||
* [Dedupfs](https://github.com/ajkr/dedupfs): an example for plugin developers to reference | |||
* [ZenFS](https://github.com/westerndigitalcorporation/zenfs): a file system for zoned block devices | |||
* [RADOS](https://github.com/riversand963/rocksdb-hdfs-env): an Env used for interacting with RADOS. Migrated from RocksDB main repo. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you double check the URL? The RADOS item has "rocksdb-hdfs-env" in it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
2a95bd2
to
7aa48e9
Compare
Thanks @ajkr for the review! |
Summary: Not a CMake expert, and the current CMake build support added by this PR is unlikely the best way of doing it. Sending out the PR to demonstrate it can work. Test Plan: Will need to update https://github.com/ajkr/dedupfs with CMake build. Also, PR facebook#9170 and PR facebook#9206 both include CMake support for their plugins, and can be used as a proof of concept.
Summary: Not a CMake expert, and the current CMake build support added by this PR is unlikely the best way of doing it. Sending out the PR to demonstrate it can work. Pull Request resolved: #9214 Test Plan: Will need to update https://github.com/ajkr/dedupfs with CMake build. Also, PR #9170 and PR #9206 both include CMake support for their plugins, and can be used as a proof of concept. Reviewed By: ajkr Differential Revision: D32738273 Pulled By: riversand963 fbshipit-source-id: da87fb4377c716bbbd577a69763b48d22483f845
7aa48e9
to
d2e279c
Compare
@riversand963 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
d2e279c
to
e0f1e7e
Compare
@riversand963 has updated the pull request. You must reimport the pull request before landing. |
@riversand963 has updated the pull request. You must reimport the pull request before landing. |
@riversand963 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
In rocksdb 7.0, all envlibrados files were moved to a separate repository (ref: facebook/rocksdb#9206). The new repo is temporary and serves as an example before it is finalized where and who to host RADOS support. Since this new repo is outside of the rocksdb repo and in an unceratin state, we should remove support for it in main and Reef test suites. Quincy and below still use rocksdb 6.0, so the same does not apply. Fixes: https://tracker.ceph.com/issues/59057 Signed-off-by: Laura Flores <lflores@redhat.com>
In rocksdb 7.0, all envlibrados files were moved to a separate repository (ref: facebook/rocksdb#9206). The new repo is temporary and serves as an example before it is finalized where and who to host RADOS support. Since this new repo is outside of the rocksdb repo and in an unceratin state, we should remove support for it in main and Reef test suites. Quincy and below still use rocksdb 6.0, so the same does not apply. Fixes: https://tracker.ceph.com/issues/59057 Signed-off-by: Laura Flores <lflores@redhat.com> (cherry picked from commit 2fca433)
In rocksdb 7.0, all envlibrados files were moved to a separate repository (ref: facebook/rocksdb#9206). The new repo is temporary and serves as an example before it is finalized where and who to host RADOS support. Since this new repo is outside of the rocksdb repo and in an unceratin state, we should remove support for it in main and Reef test suites. Quincy and below still use rocksdb 6.0, so the same does not apply. Fixes: https://tracker.ceph.com/issues/59057 Signed-off-by: Laura Flores <lflores@redhat.com>
In rocksdb 7.0, all envlibrados files were moved to a separate repository (ref: facebook/rocksdb#9206). The new repo is temporary and serves as an example before it is finalized where and who to host RADOS support. Since this new repo is outside of the rocksdb repo and in an unceratin state, we should remove support for it in main and Reef test suites. Quincy and below still use rocksdb 6.0, so the same does not apply. Fixes: https://tracker.ceph.com/issues/59057 Signed-off-by: Laura Flores <lflores@redhat.com>
In rocksdb 7.0, all envlibrados files were moved to a separate repository (ref: facebook/rocksdb#9206). The new repo is temporary and serves as an example before it is finalized where and who to host RADOS support. Since this new repo is outside of the rocksdb repo and in an unceratin state, we should remove support for it in main and Reef test suites. Quincy and below still use rocksdb 6.0, so the same does not apply. Fixes: https://tracker.ceph.com/issues/59057 Signed-off-by: Laura Flores <lflores@redhat.com>
In rocksdb 7.0, all envlibrados files were moved to a separate repository (ref: facebook/rocksdb#9206). The new repo is temporary and serves as an example before it is finalized where and who to host RADOS support. Since this new repo is outside of the rocksdb repo and in an unceratin state, we should remove support for it in main and Reef test suites. Quincy and below still use rocksdb 6.0, so the same does not apply. Fixes: https://tracker.ceph.com/issues/59057 Signed-off-by: Laura Flores <lflores@redhat.com>
This PR moves RADOS support from RocksDB repo to a separate repo. The new (temporary?) repo
in this PR serves as an example before we finalize the decision on where and who to host RADOS support. At this point,
people can start from the example repo and fork.
The goal is to include this commit in RocksDB 7.0 release.
Reference:
https://github.com/ajkr/dedupfs by @ajkr
Test plan:
Follow instructions in https://github.com/riversand963/rocksdb-rados-env/blob/main/README.md and build
test binary
env_librados_test
and run it.Also, make check