Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2/4][ResourceMngmt] Add new API CacheReservationManager::GetTotalMemoryUsage() #9071

Closed
wants to merge 7 commits into from
Closed

[2/4][ResourceMngmt] Add new API CacheReservationManager::GetTotalMemoryUsage() #9071

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
c487f27
Add new API
hx235 Oct 24, 2021
e811d7a
Clarify some CRM class comments
hx235 Oct 24, 2021
7d9431a
Replace std::atomic<std::size_t> memory_used_ with std::size_t
hx235 Oct 26, 2021
25f3df0
Clarify class comments on not thread-safe issue
hx235 Oct 26, 2021
bcf0a4e
Reword
hx235 Oct 26, 2021
8423984
Add empty line at EOF
hx235 Oct 26, 2021
145983a
Feedback: remove confusing API comment
hx235 Nov 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Clarify class comments on not thread-safe issue
  • Loading branch information
@hx235
hx235 committed Nov 9, 2021
commit 25f3df0db07bf291ddc76a66630a075ca24ce33a
4 changes: 3 additions & 1 deletion cache/cache_reservation_manager.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,9 @@ namespace ROCKSDB_NAMESPACE {

// CacheReservationManager is for reserving cache space for the memory used
// through inserting/releasing dummy entries in the cache.
// This class is NOT thread-safe.

// This class is NOT thread-safe, except that GetTotalReservedCacheSize()
// can be called without external synchronization.
class CacheReservationManager {
public:
// Construct a CacheReservationManager
Expand Down