Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1/4][PerfImprove][ResourceMngmt] Deallocate payload of BlockBasedTableBuilder::Rep::FilterBlockBuilder earlier for Full/PartitionedFilter #9070

Closed
Closed
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
33df98c
Early deallocation of BlockBasedTableBuilder::Rep::FilterBlockBuilder
hx235 Oct 24, 2021
2d9e438
Update HISTORY.md
hx235 Oct 24, 2021
5c0b5b2
Early dellocate filter data payload instead of the FilterBlockBuilder…
hx235 Oct 26, 2021
7379a51
Update HISTORY.md
hx235 Oct 26, 2021
ba04424
Default valued filter_data
hx235 Oct 26, 2021
1f47508
Reword HISTORY.md
hx235 Oct 26, 2021
de05361
Some polishing
hx235 Oct 26, 2021
517364b
Move filter_data.reset(); in the loop/remove r->filter_builder.reset(…
hx235 Oct 26, 2021
540df79
Move declaration filter_data inside the loop
hx235 Oct 26, 2021
cb767df
try to fail some test
hx235 Oct 26, 2021
cdc0cd4
Fix a bug causing new logic not to be executed
hx235 Oct 26, 2021
b526afa
Clarify FilterBlock::Finish interface
hx235 Oct 26, 2021
91f09e6
Handle partitioned filter case & add tests
hx235 Oct 28, 2021
a7207b2
Updated HISTORY.md
hx235 Oct 28, 2021
7798baa
Fix some format
hx235 Oct 28, 2021
4901410
remove redundant test
hx235 Oct 29, 2021
8ab01c5
Unify filters and filter_gc
hx235 Oct 29, 2021
7d69f58
Make format
hx235 Oct 29, 2021
b31db63
Remove changes to table_test
hx235 Oct 29, 2021
37488c6
Remove comment for weird api
hx235 Oct 30, 2021
581ef76
Fix edge case when partitioned filter passsed in nullptr output param
hx235 Nov 2, 2021
1d3003b
Simplify the writing in FullFilterBlockBuilder::Finish's return
hx235 Nov 2, 2021
732cfcb
reset last_filter_data after filters empty
hx235 Nov 3, 2021
d80cf48
Moved HISTORY update to correct section
hx235 Nov 4, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix some format
  • Loading branch information
hx235 committed Nov 3, 2021
commit 7798baa65c5f57b045604e24f0c6ef9dfa3c075b
7 changes: 4 additions & 3 deletions table/block_based/filter_block.h
Original file line number Diff line number Diff line change
Expand Up @@ -78,9 +78,10 @@ class FilterBlockBuilder {
// possible.
//
// For FullFilterBlockBuilder, the transferred filter data payload belongs to
// the CURRENT returned filter content. For PartitionedFilterBlockBuilder, the
// transferred filter data payload belongs to the PREVIOUS returned filter
// content. For BlockBasedFilterBlockBuilder, it does not transfer.
// the CURRENT returned filter content.
// For PartitionedFilterBlockBuilder, the transferred filter data payload
// belongs to the PREVIOUS returned filter content.
// For BlockBasedFilterBlockBuilder, it does not transfer.
virtual Slice Finish(
const BlockHandle& tmp /* only used in PartitionedFilterBlock as
last_partition_block_handle */
Expand Down
1 change: 0 additions & 1 deletion table/block_based/partitioned_filter_block.cc
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,6 @@ Slice PartitionedFilterBlockBuilder::Finish(
*filter_data = std::move(filter_gc.front());
filter_gc.pop_front();
}

} else {
MaybeCutAFilterBlock(nullptr);
}
Expand Down