Inject fatal write failures to db_stress when DB is running #8479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anand1976
reviewed
Jul 1, 2021
| is_db_stopped_ = true; | ||
| } else if (!is_db_stopped_ || | ||
| s.severity() < Status::Severity::kFatalError) { | ||
| fprintf(stderr, "put or merge error: %s\n", s.ToString().c_str()); |
There was a problem hiding this comment.
If its a retryable error, we always expect the Put/Delete to succeed. Is that because the fault injection FS never injects errors on WAL writes?
There was a problem hiding this comment.
If its a retryable error, we always expect the Put/Delete to succeed. Is that because the fault injection FS never injects errors on WAL writes?
Yes, in the current fault injection, we set for SST, Manifest, and Current. #8479 (comment)
anand1976
approved these changes
Jul 1, 2021
|
@zhichao-cao has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
@zhichao-cao merged this pull request in a95a776. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add the injest_error_severity to control if it is a retryable IO Error or a fatal or unrecoverable error. Use a flag to indicate, if fatal error comes, the flag is set and db is stopped (but not corrupted).
test plan: run ./db_stress --reopen=0 --read_fault_one_in=1000 --write_fault_one_in=5 --disable_wal=true --write_buffer_size=3000000 -writepercent=5 -readpercent=50 --injest_error_severity=2 --column_families=1, make check