{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":11131631,"defaultBranch":"main","name":"fbthrift","ownerLogin":"facebook","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2013-07-02T18:15:51.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/69631?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1727103796.0","currentOid":""},"activityList":{"items":[{"before":"180b6f18db0982f4caf90bc16640ac7b1b85d8a0","after":"58c397873daa96b79a12ab6236ca9c3619be3920","ref":"refs/heads/main","pushedAt":"2024-09-28T16:35:22.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Updating submodules\n\nSummary:\nGitHub commits:\n\nhttps://github.com/facebook/buck2-prelude/commit/1f7b2de93b0a6b51d852bd3750101832732a4485\nhttps://github.com/facebook/fb303/commit/5ff7b80d4f17b23b58926942d3e6155a0f452f05\nhttps://github.com/facebook/fbthrift/commit/180b6f18db0982f4caf90bc16640ac7b1b85d8a0\nhttps://github.com/facebook/folly/commit/5919fbf60818770d7f48cce45b713d5b9976bf0e\nhttps://github.com/facebook/mvfst/commit/3f21e7130c7760afb75bea92eb1bbb8f75b9628d\nhttps://github.com/facebook/proxygen/commit/1b20a4858ad97269e28a8b3916febc73691f85b2\nhttps://github.com/facebook/wangle/commit/b40784264746ddc5ce6114092f4424742690c027\nhttps://github.com/facebookexperimental/edencommon/commit/86502f809372634971aa256957d541e07203c729\nhttps://github.com/facebookexperimental/rust-shed/commit/755c0aadd12bc9ddbbc854b02578a75e70c58d7c\nhttps://github.com/facebookincubator/fizz/commit/b18b82571b6079a11abdb96e783f35f7d9fc8298\n\nReviewed By: zpao\n\nfbshipit-source-id: 358572a10d4feae64af572c93599e7fa678c049b","shortMessageHtmlLink":"Updating submodules"}},{"before":"b71f6cb1900855d85eb6e219b92e6d96124dd870","after":"180b6f18db0982f4caf90bc16640ac7b1b85d8a0","ref":"refs/heads/main","pushedAt":"2024-09-28T00:15:43.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Remove non-existent types\n\nSummary:\n`I08` and `UTF7` are not valid Thrift types. Not used and not needed.\n\nhttps://internalfb.com/intern/staticdocs/thrift/docs/idl/#primitive-types\n\nReviewed By: podtserkovskiy\n\nDifferential Revision: D63548836\n\nfbshipit-source-id: 3a3ff9ef1591c9b4dfe6afd4621710770e8c2323","shortMessageHtmlLink":"Remove non-existent types"}},{"before":"57d6ca5edcc16166e77f751e3db88bdbe3b107e2","after":"b71f6cb1900855d85eb6e219b92e6d96124dd870","ref":"refs/heads/main","pushedAt":"2024-09-27T23:53:56.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Add reflect package to collisions map\n\nSummary:\nWe will begin using \"reflect\" downstream.\nEnsure that collisions are handled properly.\n\nReviewed By: leoleovich\n\nDifferential Revision: D63477977\n\nfbshipit-source-id: 1ebf50ebafcd636faaa4762a98c7bd8eb74fab06","shortMessageHtmlLink":"Add reflect package to collisions map"}},{"before":"36cfcd5209dd27f860accc81e263bc802995c41e","after":"57d6ca5edcc16166e77f751e3db88bdbe3b107e2","ref":"refs/heads/main","pushedAt":"2024-09-27T21:01:10.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Fix bug in `BinaryPatch::apply(std::string)`\n\nSummary:\nfacepalm\n\nCurrently applies to an empty string and replace the original value, which drops the data in the original value.\n\nUnfortunately, we only had unit-test for assign operation, so we did not catch this issue.\n\nReviewed By: thedavekwon\n\nDifferential Revision: D63547473\n\nfbshipit-source-id: 96324cc3a2533a945a6e7273f9303b4d48e8a92f","shortMessageHtmlLink":"Fix bug in <code>BinaryPatch::apply(std::string)</code>"}},{"before":"2e953f2df73b705b06b79f3ff6c35012f57abcaf","after":"36cfcd5209dd27f860accc81e263bc802995c41e","ref":"refs/heads/main","pushedAt":"2024-09-27T20:01:57.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Add use_reflect_codec option\n\nSummary:\nAn option to tell Thrift-Go generator to use the new reflect codec (implemented downstream).\n\nAs is - the diff is no-op.\n\nReviewed By: leoleovich\n\nDifferential Revision: D63473895\n\nfbshipit-source-id: 66d5d630b88b7cd68b4d075ed191fe136e2171cb","shortMessageHtmlLink":"Add use_reflect_codec option"}},{"before":"ca9f3b47ff6c069bb0378de0203c80990fae5414","after":"2e953f2df73b705b06b79f3ff6c35012f57abcaf","ref":"refs/heads/main","pushedAt":"2024-09-27T17:41:12.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Fix metadata bug\n\nSummary:\nWe were missing some types from metadata.\n\nThis bug went unnoticed because it has no effect on Thrift Fiddle performance/correctness.\n\nHowever, it has an effect on the metadata work I am doing downstream, so let's fix it.\n\nReviewed By: leoleovich\n\nDifferential Revision: D63495649\n\nfbshipit-source-id: 916048ac625d3058bf862082694e72e80d2a02aa","shortMessageHtmlLink":"Fix metadata bug"}},{"before":"574f16089326c1ba3b0c8357506bd7ddce33c842","after":"ca9f3b47ff6c069bb0378de0203c80990fae5414","ref":"refs/heads/main","pushedAt":"2024-09-27T16:36:05.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Updating submodules\n\nSummary:\nGitHub commits:\n\nhttps://github.com/facebook/buck2-prelude/commit/c27699bdb4c0a50ce2c7fab9a055f8b31d4e7ac2\nhttps://github.com/facebook/fb303/commit/029cea5bef4817918008b35df499fdaba86e83ee\nhttps://github.com/facebook/fbthrift/commit/574f16089326c1ba3b0c8357506bd7ddce33c842\nhttps://github.com/facebook/folly/commit/b87bb9b92edf659f63d7d773d3e958159f49df89\nhttps://github.com/facebook/mvfst/commit/48f66699d7d0020f8b297b55f5c181179642a415\nhttps://github.com/facebook/proxygen/commit/c21584624193a857be2ebd0e3a110ac4121ae078\nhttps://github.com/facebook/wangle/commit/78747ac22220608df65ae337c1ad05827fc55165\nhttps://github.com/facebookexperimental/edencommon/commit/2d468145e0df56883a01ecd96d172dcfd56b5d71\nhttps://github.com/facebookexperimental/rust-shed/commit/d9e7e174ef7bc7384bde2446ffa94f690b4f026a\nhttps://github.com/facebookincubator/fizz/commit/c4ee5419041d6b2267e004c109364381e60d3758\n\nReviewed By: ajb85\n\nfbshipit-source-id: 8f8df9b1c3642a5b6cb87d8bf31d39f50bffaf62","shortMessageHtmlLink":"Updating submodules"}},{"before":"883b9711190a06e6d568ac8b719761adbad0d8ec","after":"574f16089326c1ba3b0c8357506bd7ddce33c842","ref":"refs/heads/main","pushedAt":"2024-09-27T14:20:56.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Extract setDefaults method\n\nSummary:\nI need this functionality extracted.\nIt will be invoked downstream by the reflection decoder to apply defaults to a blank struct.\n\nReviewed By: leoleovich\n\nDifferential Revision: D63505752\n\nfbshipit-source-id: 6371e0d295facc44f21a8372aa5a42a9a6d0f58f","shortMessageHtmlLink":"Extract setDefaults method"}},{"before":"4788293ba96fdbebb4a1fe29e247ac0ee72dd0ac","after":"883b9711190a06e6d568ac8b719761adbad0d8ec","ref":"refs/heads/main","pushedAt":"2024-09-27T09:44:43.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Add SEParallelConcurrencyController mode to conformance stresstest\n\nReviewed By: robertroeser\n\nDifferential Revision: D63459838\n\nfbshipit-source-id: 583c90b0efd55efd7a1d3fc2a48ae31fc2852707","shortMessageHtmlLink":"Add SEParallelConcurrencyController mode to conformance stresstest"}},{"before":"9147a5b832d82b3e6b6a55ac6b98863fec72a9c0","after":"4788293ba96fdbebb4a1fe29e247ac0ee72dd0ac","ref":"refs/heads/main","pushedAt":"2024-09-27T01:12:18.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Add extra_validation: implicit_field_id\n\nSummary: Turns missing field ids into an error (instead of warning).\n\nReviewed By: thedavekwon\n\nDifferential Revision: D63488400\n\nfbshipit-source-id: f5595ecc12a59d62f0ca5598673be366b3ab53e9","shortMessageHtmlLink":"Add extra_validation: implicit_field_id"}},{"before":"4978417e0f13317df962783d203f956e64aa9a36","after":"9147a5b832d82b3e6b6a55ac6b98863fec72a9c0","ref":"refs/heads/main","pushedAt":"2024-09-27T00:48:39.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"minor refactor makeRequestRpcMetadata\n\nSummary: `makeRequestRpcMetadata` does not need to take `ProtocolId`, it is from `header` anyway.\n\nReviewed By: tlj77\n\nDifferential Revision: D63470903\n\nfbshipit-source-id: afc7f0dabacb8b7e2b2b063ad8cd0909c673de23","shortMessageHtmlLink":"minor refactor makeRequestRpcMetadata"}},{"before":"66bfc6f57aa5054a8125f4e6e989b36080000f67","after":"4978417e0f13317df962783d203f956e64aa9a36","ref":"refs/heads/main","pushedAt":"2024-09-26T23:18:58.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Support AnyData in AnyPatch\n\nSummary: Support interoperability with the most commonly adapted version of AnyStruct (i.e. AnyData) until we properly support adapted types\n\nReviewed By: thedavekwon\n\nDifferential Revision: D63478001\n\nfbshipit-source-id: 9908f06493aae1d11344b0c807310d5e9cdf7263","shortMessageHtmlLink":"Support AnyData in AnyPatch"}},{"before":"580889b47dcd74ede18a68e197d7c7a4379d8fec","after":"66bfc6f57aa5054a8125f4e6e989b36080000f67","ref":"refs/heads/main","pushedAt":"2024-09-26T19:57:16.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"move setCompression to makeRequestRpcMetadata\n\nSummary:\nrefactor makeRequestRpcMetadata method to handle compression config related logic.\n\nWith this change, we are close to apply CurSe to RequestRpcMetadata serialization.\n\nReviewed By: AkramaMirza\n\nDifferential Revision: D63407672\n\nfbshipit-source-id: a9ac6c4c59feda1e0ac346ac13e6ccfb77d5744f","shortMessageHtmlLink":"move setCompression to makeRequestRpcMetadata"}},{"before":"f3d34c9f67ade70ef5730d510620b5d87055e242","after":"580889b47dcd74ede18a68e197d7c7a4379d8fec","ref":"refs/heads/main","pushedAt":"2024-09-26T18:43:53.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Migrate thrift server stats to Fast Stats lib to avoid lock contention\n\nSummary: Airlift stats use synchronization instead of lock free or wait free semantics causing lock contention on high core count. This change moves distributions and EWMA counters to use lock free semantics to avoid locking under high load write scenarios.\n\nReviewed By: AGFeldman\n\nDifferential Revision: D62396291\n\nfbshipit-source-id: 8f57e7f529ecd1af14accad8de3eb1b10a3065a9","shortMessageHtmlLink":"Migrate thrift server stats to Fast Stats lib to avoid lock contention"}},{"before":"794072cd6e425664ea15fa1f28b5f4c7da0fe97b","after":"f3d34c9f67ade70ef5730d510620b5d87055e242","ref":"refs/heads/main","pushedAt":"2024-09-26T16:34:15.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Updating submodules\n\nSummary:\nGitHub commits:\n\nhttps://github.com/facebook/buck2-prelude/commit/48bacb3ccac7a9582c49fbea41b1ed2d638ba4ab\nhttps://github.com/facebook/fb303/commit/48bf2dd8c4bcc255b98827e576be45ae98d6b658\nhttps://github.com/facebook/fbthrift/commit/794072cd6e425664ea15fa1f28b5f4c7da0fe97b\nhttps://github.com/facebook/folly/commit/c33e68c1676ae4082ae8eea3bb9b3d23dbf6398f\nhttps://github.com/facebook/mvfst/commit/a268c9336d291400fcd5a091f2e117d649535a91\nhttps://github.com/facebook/proxygen/commit/642241f5bc4f1fafbf56d1003a97ee9f07faaae0\nhttps://github.com/facebook/wangle/commit/217add600927756f3a167e68f51062b8392089ed\nhttps://github.com/facebookexperimental/edencommon/commit/55b5a75c7f449c6b8f4b9262335b21951b356c64\nhttps://github.com/facebookexperimental/rust-shed/commit/c22f773e5375d59a3de0cd48dc67f8fc449314ae\nhttps://github.com/facebookincubator/fizz/commit/d72546955359d1702ef498d0e07bd0f4658a7757\n\nReviewed By: ajb85\n\nfbshipit-source-id: e7be6cf33e5ed1b50dec46340102adf4ec5231e9","shortMessageHtmlLink":"Updating submodules"}},{"before":"ea7fad73cf7e8a19a7b4bbee06e39937b68a61e4","after":"794072cd6e425664ea15fa1f28b5f4c7da0fe97b","ref":"refs/heads/main","pushedAt":"2024-09-26T14:40:53.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Add new function to initialize MRL\n\nSummary: Add a new initializer for MRL checker to gradually move its definition to Configerator API level ([more context](https://fburl.com/gdoc/ns5cc59a)).\n\nReviewed By: frqiu\n\nDifferential Revision: D61947369\n\nfbshipit-source-id: 6f72bce41d85408e697db661f30b6b0ba8185cea","shortMessageHtmlLink":"Add new function to initialize MRL"}},{"before":"1bec44a6b984c03dd962f4ac6f694d55d1f1fefc","after":"ea7fad73cf7e8a19a7b4bbee06e39937b68a61e4","ref":"refs/heads/main","pushedAt":"2024-09-26T00:06:02.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Avoid extra copy when applying r-value Patch\n\nSummary:\nCurrently `apply` is a const method, which would copy the data. If we can discard the patch after applying, we can move the data instead.\n\nThis diff optimized for StringPatch, eventually we want to use the same technique to optimize for other patches.\n\nReviewed By: thedavekwon\n\nDifferential Revision: D63044259\n\nfbshipit-source-id: f73859ec558747c8cb66be165d2723cfd464e832","shortMessageHtmlLink":"Avoid extra copy when applying r-value Patch"}},{"before":"215ce68ea8cc8b3858c3bd28f16091cad3b21653","after":"1bec44a6b984c03dd962f4ac6f694d55d1f1fefc","ref":"refs/heads/main","pushedAt":"2024-09-25T23:12:04.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"drop `_ref()` in RpcMetadataUtil\n\nSummary: `field()` and `field_ref()` are the same thing in this context, we can drop `_ref()` for clarity.\n\nReviewed By: robertroeser\n\nDifferential Revision: D63398091\n\nfbshipit-source-id: ec304938e07f88c45efb630ba0e03d6120730363","shortMessageHtmlLink":"drop <code>_ref()</code> in RpcMetadataUtil"}},{"before":"8f43f51dbd10593426ff73928ccff11d034c7263","after":"215ce68ea8cc8b3858c3bd28f16091cad3b21653","ref":"refs/heads/main","pushedAt":"2024-09-25T22:14:14.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"remove some unused Asserts and DChecks\n\nSummary: `name`, `protocol` and `kind` are guarantee to be set in `makeRequestRpcMetadata` method, we do not really need these un-necessary sDCHECK`s and `assert`s\n\nReviewed By: tlj77\n\nDifferential Revision: D63348008\n\nfbshipit-source-id: d94a3ede9f889d0594cf83ab4839156e5bb19362","shortMessageHtmlLink":"remove some unused Asserts and DChecks"}},{"before":"f10a1a154379bd29647e0db05379fa5cd02d8d43","after":"8f43f51dbd10593426ff73928ccff11d034c7263","ref":"refs/heads/main","pushedAt":"2024-09-25T22:05:06.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"ParseObject benchmarks\n\nSummary:\nAdd a benchmark to demonstrate partial parse object performance.\n\n```\n============================================================================\n[...]benchmarks/parse_object_benchmark.cpp     relative  time/iter   iters/s\n============================================================================\nOpDecodeComplexStruct_Compact                             147.66ms      6.77\nParseObjectComplexStruct_Compact                20.895%   706.69ms      1.42\nOpDecodeMixed_Compact                                      35.34ns    28.29M\nParseObjectMixed_Compact                        18.098%   195.29ns     5.12M\nParseObjectMixedWithMaskFromComplexStruct_Compa6.6622e-05%    53.05ms     18.85\nOpDecodeComplexStruct_Binary                              115.66ms      8.65\nParseObjectComplexStruct_Binary                 16.908%   684.07ms      1.46\nOpDecodeMixed_Binary                                       30.91ns    32.36M\nParseObjectMixed_Binary                         17.550%   176.10ns     5.68M\nParseObjectMixedWithMaskFromComplexStruct_Binar0.00010967%    28.18ms     35.49\n```\n\nFew interesting notes:\n1. `ParseObjectMixedWithMaskFromComplexStruct` is about twice faster in binary protocol as skipping is much more efficient.\n2. ParseObjectMixedWithMaskFromComplexStruct takes significant times in skipping ~99% time as we want to extract tiny portion of the data from the mask. [strobelight](https://www.internalfb.com/intern/strobelight/ondemand/?dataset=strobelight_services%2Fon_demand&drillstate=%7B%22dimensions%22%3A%5B%22process%22%5D%2C%22param_dimensions%22%3A%5B%7B%22anchor%22%3A%220%22%2C%22param%22%3A%220%22%2C%22op%22%3A%22all%22%2C%22dim%22%3A%22stack_combined%22%7D%5D%2C%22constraints%22%3A%5B%5B%7B%22value%22%3A%5B%22%5B%5C%227083985589358813%5C%22%5D%22%5D%2C%22op%22%3A%22eq%22%2C%22column%22%3A%22run_id%22%7D%2C%7B%22value%22%3A%5B%22%5B%5C%22dokwon%5C%22%5D%22%5D%2C%22op%22%3A%22eq%22%2C%22column%22%3A%22run_user%22%7D%2C%7B%22value%22%3A%5B%22%5B%5C%22strobelight_cli%5C%22%5D%22%5D%2C%22op%22%3A%22all%22%2C%22column%22%3A%22sample_tags%22%7D%5D%5D%2C%22top%22%3A100000%2C%22end%22%3A%221727138641%22%2C%22start%22%3A%221727131441%22%7D&view=Icicle3&=&icicle_state=%7B%22deltaMode%22%3A%22none%22%2C%22colorMode%22%3A%22total%22%2C%22valueMode%22%3A%22selection%22%2C%22formatMode%22%3A%22percentage%22%2C%22codeHubState%22%3A%7B%22aggregationField%22%3A%22%22%2C%22scubaParams%22%3A%22%22%2C%22symbolPath%22%3Anull%7D%2C%22showCodeProfileModal%22%3Afalse%2C%22colorPatterns%22%3A%5B%5D%7D)\n\nReviewed By: pranavtbhat\n\nDifferential Revision: D63296993\n\nfbshipit-source-id: 492593734fa24db1e034dec633667fd561250541","shortMessageHtmlLink":"ParseObject benchmarks"}},{"before":"5fcf01b78d6db6a661915eeb30958c2941603aba","after":"f10a1a154379bd29647e0db05379fa5cd02d8d43","ref":"refs/heads/main","pushedAt":"2024-09-25T20:41:47.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"move timeout management logic out of preSendValidation method\n\nSummary:\nin this diff, we move timeout management logic out of `preSendValidation` method\n\nthe logic to compute clientTimeout is pulled to `getClientTimeout`\nthe logic to skip setting timeouts in RpcMetadata if `rpcOptions.getClientOnlyTimeouts()` is set is moved to `makeRequestRpcMetadata`\n\nReviewed By: robertroeser\n\nDifferential Revision: D63304569\n\nfbshipit-source-id: 5dfec5496a64e6b9e133ae4bad26ecb7820e3db7","shortMessageHtmlLink":"move timeout management logic out of preSendValidation method"}},{"before":"ef25d8e7742e9e8adec0f01930eee11084885f72","after":"5fcf01b78d6db6a661915eeb30958c2941603aba","ref":"refs/heads/main","pushedAt":"2024-09-25T20:12:51.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Make InferTag SFINAE-friendly\n\nReviewed By: iahs\n\nDifferential Revision: D63038626\n\nfbshipit-source-id: 404d84879b765b630eff6a2bc1b5a78277a9fd65","shortMessageHtmlLink":"Make InferTag SFINAE-friendly"}},{"before":"7ad6188b7ca54715d679c58137a629a5f13173ba","after":"ef25d8e7742e9e8adec0f01930eee11084885f72","ref":"refs/heads/main","pushedAt":"2024-09-25T17:40:04.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"preSendValidation no longer need to return bool\n\nSummary:\nwe moved all the logic that returns bool out of `preSendValidation` in the previous diff D63280947,\n\nnow `preSendValidation` no longer need to return bool\n\nReviewed By: vitaut\n\nDifferential Revision: D63300724\n\nfbshipit-source-id: a237cc586fe85b49ac903602165255a4acb14717","shortMessageHtmlLink":"preSendValidation no longer need to return bool"}},{"before":"eda1241d79ed1894b0a3ac06894f7aff46165b01","after":"7ad6188b7ca54715d679c58137a629a5f13173ba","ref":"refs/heads/main","pushedAt":"2024-09-25T17:09:38.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Codemod thrift/lib/py3/test/testing.thrift\n\nSummary: TSIA\n\nDifferential Revision: D63355367\n\nfbshipit-source-id: d369c2f9af3271727244a40c8bd2a89a08578c3a","shortMessageHtmlLink":"Codemod thrift/lib/py3/test/testing.thrift"}},{"before":"23aefd7e362ae432378df8a44fc7d7b0354eb77e","after":"eda1241d79ed1894b0a3ac06894f7aff46165b01","ref":"refs/heads/main","pushedAt":"2024-09-25T16:35:07.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Updating submodules\n\nSummary:\nGitHub commits:\n\nhttps://github.com/facebook/buck2-prelude/commit/766c3b721bc65baf42df0848a3a0b78aec625f7b\nhttps://github.com/facebook/fb303/commit/101a18a515213becc9a4ea7b066c1247f408246b\nhttps://github.com/facebook/fbthrift/commit/23aefd7e362ae432378df8a44fc7d7b0354eb77e\nhttps://github.com/facebook/folly/commit/536f70bc870ed7fe617900f78deac6194c552255\nhttps://github.com/facebook/mvfst/commit/969a325a4217e94d2d17a20c7bfd46a8dfe426c6\nhttps://github.com/facebook/proxygen/commit/17e3fc052800e62860de6fcda45e43a4927b462e\nhttps://github.com/facebook/wangle/commit/e6b370028561dd32f54dd38907c55eef05529675\nhttps://github.com/facebookexperimental/edencommon/commit/de3dbc73a1b7b3eeaf63f648f7347f75d587f5b1\nhttps://github.com/facebookexperimental/rust-shed/commit/037e667e695f390be258db96af01df9a3d0013c1\nhttps://github.com/facebookincubator/fizz/commit/9a61414973e1933432d4d3ea077c5611d33de35c\n\nReviewed By: ajb85\n\nfbshipit-source-id: 09a5bf24ce5a625907dfd511718974388511d7a9","shortMessageHtmlLink":"Updating submodules"}},{"before":"cb69dd59771572da027f77bc9e624003e9de45b9","after":"23aefd7e362ae432378df8a44fc7d7b0354eb77e","ref":"refs/heads/main","pushedAt":"2024-09-25T14:36:30.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Consider upgrading fbcode/thrift/conformance/go's thrift.NewSimpleServer to use thrift.TransportIDUpgradeToRocket\n\nSummary: Please consider upgrading fbcode/thrift/conformance/go's thrift.NewSimpleServer to use thrift.TransportIDUpgradeToRocket. See https://fb.workplace.com/groups/codegophers/permalink/26891400743815186/ for more details. Please test in production and let us know of any issues.\n\nReviewed By: thedavekwon\n\nDifferential Revision: D63321910\n\nfbshipit-source-id: ab03e554e1e4599e8f918372bcbfeef74b97c8f8","shortMessageHtmlLink":"Consider upgrading fbcode/thrift/conformance/go's thrift.NewSimpleSer…"}},{"before":"00e2f01d764ec6af3984d2d0b9309ef6655da587","after":"cb69dd59771572da027f77bc9e624003e9de45b9","ref":"refs/heads/main","pushedAt":"2024-09-25T13:51:18.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"make transport explicit in final thrift.NewClient calls\n\nSummary: make transport explicit in final thrift.NewClient calls\n\nReviewed By: echistyakov\n\nDifferential Revision: D63327716\n\nfbshipit-source-id: 3311ea7eb62bbcb4adeb0f11a4fa5cfa618fada4","shortMessageHtmlLink":"make transport explicit in final thrift.NewClient calls"}},{"before":"0e17ae9d613f1fcb459b7240b0b7712603a570ac","after":"00e2f01d764ec6af3984d2d0b9309ef6655da587","ref":"refs/heads/main","pushedAt":"2024-09-25T13:37:19.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Consider upgrading fbcode/thrift/perf/go/server's thrift.NewSimpleServer to use thrift.TransportIDUpgradeToRocket\n\nSummary: Please consider upgrading fbcode/thrift/perf/go/server's thrift.NewSimpleServer to use thrift.TransportIDUpgradeToRocket. See https://fb.workplace.com/groups/codegophers/permalink/26891400743815186/ for more details. Please test in production and let us know of any issues.\n\nReviewed By: leoleovich\n\nDifferential Revision: D63321921\n\nfbshipit-source-id: 893a4e6363adac66834a25142eef03914d8b215e","shortMessageHtmlLink":"Consider upgrading fbcode/thrift/perf/go/server's thrift.NewSimpleSer…"}},{"before":"f39222c82997eca96e4a8b7bacd561c9ef36b4fb","after":"0e17ae9d613f1fcb459b7240b0b7712603a570ac","ref":"refs/heads/main","pushedAt":"2024-09-25T09:19:39.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"make transport explicit in more thrift.NewClient calls\n\nSummary: make transport explicit in more thrift.NewClient calls\n\nReviewed By: podtserkovskiy\n\nDifferential Revision: D63323553\n\nfbshipit-source-id: dc08232226277ecc2d63bdfbdbac35ccd1e4d77e","shortMessageHtmlLink":"make transport explicit in more thrift.NewClient calls"}},{"before":"b10e459965a213fc9b9b2ee9429ce6788594f516","after":"f39222c82997eca96e4a8b7bacd561c9ef36b4fb","ref":"refs/heads/main","pushedAt":"2024-09-25T08:31:56.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"remove unused stats\n\nSummary:\nremove unused stats\n\nThese are never updated, so we might as well remove them, that is IF and only IF we land D62497068\n\nReviewed By: podtserkovskiy\n\nDifferential Revision: D62497116\n\nfbshipit-source-id: 55fe958e1a0f16a6b0298310f2bf5a5cace1a09a","shortMessageHtmlLink":"remove unused stats"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"startCursor":"Y3Vyc29yOnYyOpK7MjAyNC0wOS0yOFQxNjozNToyMi4wMDAwMDBazwAAAATDcoyR","endCursor":"Y3Vyc29yOnYyOpK7MjAyNC0wOS0yNVQwODozMTo1Ni4wMDAwMDBazwAAAATADeOd"}},"title":"Activity · facebook/fbthrift"}