Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add performance relayer + documentation (web-vitals) #9116

Merged
merged 6 commits into from
Jun 11, 2020

Conversation

housseindjirdeh
Copy link
Contributor

@housseindjirdeh housseindjirdeh commented Jun 5, 2020

Fixes #8996

Changes included:

  • Dynamically imports the web-vitals lib
  • Includes a reportWebVitals function to index.js template (doesn't do anything until a function is passed in)
  • Adds a "Measuring Performance" page to the documentation

@facebook-github-bot
Copy link

Hi @housseindjirdeh!

Thank you for your pull request and welcome to our community.We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

Copy link
Contributor

@mrmckeb mrmckeb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't tested this, but it looks good at an overview, and the docs look great. This is something we definitely talked about getting into the next release - and I'd love to see it make it.

Thoughts @ianschmitz @iansu?

@mrmckeb mrmckeb added this to the 4.0 milestone Jun 9, 2020
Copy link
Contributor

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW, I think this is good to go 👍

@ianschmitz ianschmitz closed this Jun 10, 2020
@ianschmitz ianschmitz reopened this Jun 10, 2020
@mrmckeb
Copy link
Contributor

mrmckeb commented Jun 11, 2020

I've tested this on a project today and it works well. Obviously the extension works with or without this, but being able to report on this is really valuable.

@ianschmitz ianschmitz changed the title Adds performance relayer + documentation (web-vitals) Add performance relayer + documentation (web-vitals) Jun 11, 2020
@ianschmitz ianschmitz merged commit 8fda779 into facebook:master Jun 11, 2020
@ianschmitz
Copy link
Contributor

Thanks a ton @housseindjirdeh! Much appreciated.

@housseindjirdeh
Copy link
Contributor Author

Awesome thanks all! So happy to see this land :)

@lock lock bot locked and limited conversation to collaborators Jun 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include a performance relayer
6 participants