Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add experimental react-refresh support #8582

Merged
merged 11 commits into from
Apr 6, 2020
Merged

Add experimental react-refresh support #8582

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
de556af
Add react-refresh webpack plugin
charrondev Feb 29, 2020
78065e6
Add boolean filter to babel plugins
charrondev Feb 29, 2020
c7f0032
Add feature flag env variable for react refresh
charrondev Feb 29, 2020
aee5849
Fix refresh not occuring with warnings
charrondev Feb 29, 2020
670b60a
Remove duplicated config and update react refresh client
charrondev Mar 31, 2020
a07f4ac
Remove unnecessary dep
ianschmitz Apr 1, 2020
baa543b
Move module stub to hide from react-dev-utils
ianschmitz Apr 1, 2020
960867a
Change REACT_REFRESH to FAST_REFRESH
ianschmitz Apr 1, 2020
95ee822
Add env variable docs
ianschmitz Apr 1, 2020
4e82485
Merge remote-tracking branch 'upstream/master' into refresh
ianschmitz Apr 6, 2020
572d14c
Update refresh webpack plugin
ianschmitz Apr 6, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix refresh not occuring with warnings
  • Loading branch information
@charrondev
charrondev committed Mar 31, 2020
commit aee58491b2f538df556d46cc6a93310e91301e09
1 change: 1 addition & 0 deletions packages/react-dev-utils/webpackFastRefreshDevClient.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,7 @@ connection.onmessage = function(e) {
break;
case 'still-ok':
case 'ok':
case 'warnings': // Warnings are not fatal. We should try refreshing.
handleSuccess();
break;
case 'content-changed':
Expand Down