Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a VSCode tip in the CSS reset section #8246

Merged
merged 2 commits into from
May 5, 2020

Conversation

maazadeeb
Copy link
Contributor

A warning kept popping up in my editor. Narrowed it down to microsoft/vscode#53175. Adding the suggestion as a tip.

A warning kept popping up in my editor. Narrowed it down to microsoft/vscode#53175. Adding the suggestion as a tip.
@stale
Copy link

stale bot commented Jan 26, 2020

This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs.

@stale stale bot added the stale label Jan 26, 2020
@amyrlam amyrlam self-assigned this Jan 31, 2020
@oluoluoxenfree
Copy link

Looks good to me and @amyrlam; what do you think @ianschmitz, @iansu and co? 🙂

@amyrlam amyrlam added this to the 3.3.2 milestone Feb 4, 2020
@iansu iansu modified the milestones: 3.3.2, 3.4.1 Feb 14, 2020
@iansu iansu modified the milestones: 3.4.1, 3.4.2 Mar 20, 2020
@ianschmitz ianschmitz modified the milestones: 3.5, 4.0 May 3, 2020
@iansu iansu merged commit 6a7aaa2 into facebook:master May 5, 2020
@iansu
Copy link
Contributor

iansu commented May 5, 2020

Thanks!

@lock lock bot locked and limited conversation to collaborators May 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants