Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update issue templates #7269

Merged
merged 6 commits into from
Jun 24, 2019
Merged

Update issue templates #7269

merged 6 commits into from
Jun 24, 2019

Conversation

mrmckeb
Copy link
Contributor

@mrmckeb mrmckeb commented Jun 23, 2019

This is a simple PR to move to the newer GitHub issue format.

The bug report is based on the previous template, the proposal is based on GitHub's default proposal template (I renamed from "Feature request" to "Proposal" to align with our wording.

@iansu
Copy link
Contributor

iansu commented Jun 23, 2019

This is great. I've had this on my todo list for a long time. Does the regular template need to be updated now that we have a separate one for bug reports?

@ianschmitz
Copy link
Contributor

It looks like we can apply default labels to each template? If so do we want to do so?

@iansu
Copy link
Contributor

iansu commented Jun 23, 2019

@ianschmitz That sounds great. We should definitely add any relevant labels automatically.

I love how CI runs for these changes. Do we have any way to skip it?

@mrmckeb
Copy link
Contributor Author

mrmckeb commented Jun 23, 2019

Thanks @iansu, I forgot to delete that. That's done now. The new bug template is the same as the old, just without the "Is this a bug" question.

@ianschmitz we can... Any suggestions?

@iansu
Copy link
Contributor

iansu commented Jun 23, 2019

We have issue: proposal and issue: bug so those seem like a good starting point.

@mrmckeb
Copy link
Contributor Author

mrmckeb commented Jun 24, 2019

I agree, I couldn't think of any other options either @iansu.

@mrmckeb
Copy link
Contributor Author

mrmckeb commented Jun 24, 2019

OK, that's updated @ianschmitz and @iansu. If you're OK with this, let's get it in and see how it performs.

@iansu
Copy link
Contributor

iansu commented Jun 24, 2019

LGTM!

@iansu iansu merged commit 2eab406 into master Jun 24, 2019
@lock lock bot locked and limited conversation to collaborators Jun 29, 2019
@ianschmitz ianschmitz deleted the feature/issue-templates branch August 10, 2019 23:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants