Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolve project "realpath" on windows to avoid drive mismatch when debugging #227

Merged
merged 1 commit into from
Sep 4, 2023

Conversation

byCedric
Copy link
Member

@byCedric byCedric commented Sep 4, 2023

Linked issue

Fixes #226, #191

This workaround resolves the real path of the project root on windows, just before initializing the debugger config. It should align the drive letter with the correct casing, so VS Code knows which files are referred to when parsing the source map.

@byCedric byCedric force-pushed the fix/debug-sourcemap-windows-driveletter branch from d5fa5e1 to 9d50e02 Compare September 4, 2023 13:58
@byCedric byCedric merged commit f20d7b7 into main Sep 4, 2023
9 checks passed
@byCedric byCedric deleted the fix/debug-sourcemap-windows-driveletter branch September 4, 2023 14:23
expo-bot added a commit that referenced this pull request Sep 4, 2023
## [1.2.1](1.2.0...1.2.1) (2023-09-04)

### Bug fixes

* resolve the project "realpath" on Windows to avoid drive letter mismatch in sourcemap ([#227](#227)) ([f20d7b7](f20d7b7))
@expo-bot
Copy link
Contributor

expo-bot commented Sep 4, 2023

🎉 This PR is included in version 1.2.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@robozb
Copy link

robozb commented Sep 4, 2023

Thank you so much dear Cedric!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expo Tools debuger: could not read source map for...
3 participants