Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix entry point definition #38

Merged
merged 4 commits into from
Jul 5, 2023
Merged

fix entry point definition #38

merged 4 commits into from
Jul 5, 2023

Conversation

svlandeg
Copy link
Member

@svlandeg svlandeg commented Jul 3, 2023

Description

Running weasel on the commandline didn't actually work, because the app's location was wrongly defined.

Types of change

bug fix

Checklist

  • I confirm that I have the right to submit this contribution under the project's MIT license.
  • I ran the test suite, and all new and existing tests passed.
  • My changes don't require a change to the documentation, or if they do, I've added all required information.

@svlandeg svlandeg added the bug Something isn't working label Jul 3, 2023
@svlandeg
Copy link
Member Author

svlandeg commented Jul 3, 2023

mypy issues on CI are unrelated, cf #39

@adrianeboyd
Copy link
Contributor

Can we add a few test steps with CLI commands e.g. with --help (similar to the basic spacy CLI tests) around here (in particular before installing the test requirements):

- name: Test import
shell: bash
run: |
python -c "import $MODULE_NAME" -Werror

@svlandeg svlandeg marked this pull request as ready for review July 4, 2023 09:14
Co-authored-by: Adriane Boyd <adrianeboyd@gmail.com>
@adrianeboyd adrianeboyd merged commit 1aee2ad into main Jul 5, 2023
26 checks passed
@svlandeg svlandeg deleted the fix/app branch July 5, 2023 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants