Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add type hinting on SpanGroup.__iter__ #12642

Merged
merged 1 commit into from
May 17, 2023
Merged

feat: add type hinting on SpanGroup.__iter__ #12642

merged 1 commit into from
May 17, 2023

Conversation

bdura
Copy link
Contributor

@bdura bdura commented May 17, 2023

Description

This PR adds a type hint to SpanGroup.__iter__.

Types of change

This is a (minor) enhancement.

Checklist

  • I confirm that I have the right to submit this contribution under the project's MIT license.
  • I ran the tests, and all new and existing tests passed.
  • My changes don't require a change to the documentation, or if they do, I've added all required information.

@rmitsch rmitsch added enhancement Feature requests and improvements feat / doc Feature: Doc, Span and Token objects labels May 17, 2023
@adrianeboyd adrianeboyd merged commit 95fd46b into explosion:master May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmitsch rmitsch rmitsch approved these changes

Assignees
No one assigned
Labels
enhancement Feature requests and improvements feat / doc Feature: Doc, Span and Token objects
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bdura @rmitsch @adrianeboyd