Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New design for Staking cards #13115

Open
nloureiro opened this issue Jun 7, 2024 · 14 comments
Open

New design for Staking cards #13115

nloureiro opened this issue Jun 7, 2024 · 14 comments
Labels
dev required This requires developer resources request for comments 🗣️ A request for comments has been made; discussion and input is encouraged Status: Stale This issue is stale because it has been open 30 days with no activity.

Comments

@nloureiro
Copy link
Contributor

nloureiro commented Jun 7, 2024

Is your feature request related to a problem? Please describe.

On exploring a new color scheme for the Design system, @ddannehh ended up designing a better version of the Stake cards.

We should isolate this design and implement it under the current design system.

this is the base proposal that should be worked to be implemented under the existing design system
Screen Shot 2024-06-07 09 21 39 AM

Link to the figma file
https://www.figma.com/design/wdBEEuqbT2t94jp92DTITy/New-Staking-cards?node-id=1-3&t=fJe1FAqkufXGCf9H-1

@github-actions github-actions bot added the needs triage 📥 This issue needs triaged before being worked on label Jun 7, 2024
@ddannehh
Copy link

ddannehh commented Jun 7, 2024

@ddannehh
Copy link

ddannehh commented Jun 7, 2024

PS: Content issue, BloxStaking has been shutdown :)

@nloureiro
Copy link
Contributor Author

PS: Content issue, BloxStaking has been shutdown :)

can you open a new issue with this? it's easier to have a contributor to remove it
Thank you

@nloureiro
Copy link
Contributor Author

@wackerow, long story short, we have new cards for staking :)

what do you think?

@wackerow
Copy link
Member

wackerow commented Jun 7, 2024

Agreed. I think this looks nice, though it's obviously a minimal change from the existing design... same layout, same structure and same information. We have a bit more data collected in the data JSON that we're not really displaying, ie socials, or fees... we could also consider ways to include these values.

@wackerow
Copy link
Member

wackerow commented Jun 7, 2024

I like the switch to colored logos... the monochromatic look was challenging to maintain and arguably not worth it.

@wackerow wackerow added request for comments 🗣️ A request for comments has been made; discussion and input is encouraged design All the issues related to design should use this tag and removed needs triage 📥 This issue needs triaged before being worked on labels Jun 7, 2024
@nloureiro
Copy link
Contributor Author

Agreed. I think this looks nice, though it's obviously a minimal change from the existing design... same layout, same structure and same information. We have a bit more data collected in the data JSON that we're not really displaying, ie socials, or fees... we could also consider ways to include these values.

on nice!!!

can you add that extra data on Figma?

@ddannehh
Copy link

ddannehh commented Jun 12, 2024

Included fees in the sub-header text and added social icons at the bottom.

Saas Providers

Probably worth noting as well, the Key generators below the Saas Providers have a slightly different layout since they don't require a minimum ETH stake and have no fees

Key Generators

@nloureiro nloureiro added dev required This requires developer resources and removed design All the issues related to design should use this tag labels Jun 18, 2024
@wackerow
Copy link
Member

Yeah this looks great... like the simple addition with the socials and the fees

@wackerow
Copy link
Member

If I'm correct looks like it may pull away from DS a bit? @nloureiro checking in if this change was something you were interested in planning for or not.

@nloureiro
Copy link
Contributor Author

If I'm correct looks like it may pull away from DS a bit? @nloureiro checking in if this change was something you were interested in planning for or not.

Actually, @ddannehh made all the adjustments to make it a DS component.

From my side, it's ready to be coded unless you see some adjustments needed.

He also made a variation on the tabs that I like; it might be a different issue, but it goes a long with these cards really well.
Screen Shot 2024-06-20 09 37 31 AM

Copy link
Contributor

This issue is stale because it has been open 30 days with no activity.

@github-actions github-actions bot added the Status: Stale This issue is stale because it has been open 30 days with no activity. label Jul 21, 2024
@konopkja
Copy link
Contributor

These cards look good to me, is there any blocker for implementation? Can we give this to the contributor community?

Included fees in the sub-header text and added social icons at the bottom.

Saas Providers Probably worth noting as well, the Key generators below the Saas Providers have a slightly different layout since they don't require a minimum ETH stake and have no fees Key Generators

@konopkja konopkja removed the Status: Stale This issue is stale because it has been open 30 days with no activity. label Aug 20, 2024
Copy link
Contributor

This issue is stale because it has been open 30 days with no activity.

@github-actions github-actions bot added the Status: Stale This issue is stale because it has been open 30 days with no activity. label Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev required This requires developer resources request for comments 🗣️ A request for comments has been made; discussion and input is encouraged Status: Stale This issue is stale because it has been open 30 days with no activity.
Projects
None yet
Development

No branches or pull requests

4 participants