UHV: enable for admin interface #29737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yan Avlasov <yavlasov@google.com>
KBaichoo
reviewed
Sep 20, 2023
KBaichoo
reviewed
Sep 20, 2023
| case Http::Protocol::Http11: | ||
| return Http::Http1::CodecStats::atomicGet(http1_codec_stats_, *server_.stats().rootScope()); | ||
| case Http::Protocol::Http3: | ||
| IS_ENVOY_BUG("HTTP/3 is not supported for admin UI"); |
There was a problem hiding this comment.
Yes, UHV is enabled in compile-time-options build. Admin endpoint is used in almost every integration test, and it should also be covered by existing admin tests.
There was a problem hiding this comment.
Also added checks in the admin_test
Signed-off-by: Yan Avlasov <yavlasov@google.com>
KBaichoo
previously approved these changes
Sep 20, 2023
Signed-off-by: Yan Avlasov <yavlasov@google.com>
KBaichoo
previously approved these changes
Sep 20, 2023
|
Adding non Googler for another pass. |
Signed-off-by: Yan Avlasov <yavlasov@google.com>
wbpcode
reviewed
Sep 22, 2023
wbpcode
previously approved these changes
Sep 22, 2023
Signed-off-by: Yan Avlasov <yavlasov@google.com>
KBaichoo
approved these changes
Sep 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message:
Make admin UI use the default universal header validator, when build with the ENVOY_ENABLE_UHV. UHV config matches admin UI configuration for header validation and normalization.
Noop for the normal Envoy build.
Risk Level: Low, build flag protected
Testing: Unit Tests
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A
Fixes #29503