Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parse pantry JSON data into objects and store in list #3

Merged
merged 11 commits into from
Nov 11, 2018
Merged

Parse pantry JSON data into objects and store in list #3

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
4896c46
Implement json download and parsing
robert-w-gries Nov 4, 2018
26622e5
Fix unresolved import and hardcode language level
robert-w-gries Nov 4, 2018
b3facd1
Improve async
robert-w-gries Nov 5, 2018
0dbaa86
Final async implementation
robert-w-gries Nov 5, 2018
f29f69d
Fix incorrect IDE syntax highlighting and fix warnings
robert-w-gries Nov 6, 2018
9e3ac37
Remove unneceessary comments
robert-w-gries Nov 6, 2018
5151b1d
UI fixes and fix for tab in landscape
robert-w-gries Nov 6, 2018
f95d721
Use constraint layouts and clean up layouts
robert-w-gries Nov 8, 2018
1ab74d6
Use ViewModel to store pantry data
robert-w-gries Nov 10, 2018
57b3477
Fix list state restore and add divider
robert-w-gries Nov 11, 2018
6e34b8e
Improve details screen
robert-w-gries Nov 11, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove unneceessary comments
  • Loading branch information
@robert-w-gries
robert-w-gries committed Nov 6, 2018
commit 9e3ac37964778b607509de27f04ceefa32051727
5 changes: 0 additions & 5 deletions app/src/main/java/org/endhungerdurham/pantries/MyItemRecyclerViewAdapter.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,11 +9,6 @@ import org.endhungerdurham.pantries.ItemsFragment.OnListFragmentInteractionListe

import kotlinx.android.synthetic.main.fragment_item.view.*

/**
* [RecyclerView.Adapter] that can display a [DummyItem] and makes a call to the
* specified [OnListFragmentInteractionListener].
* TODO: Replace the implementation with code for your data type.
*/
class MyItemRecyclerViewAdapter(
private val mValues: List<Pantry>,
private val mListener: OnListFragmentInteractionListener?)
Expand Down
3 changes: 0 additions & 3 deletions app/src/main/res/values/strings.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,4 @@
<string name="pantries">Pantries</string>
<string name="map">Map</string>
<string name="pantries_json_url">https://raw.githubusercontent.com/end-hunger-durham/data-importer/master/pantries.json</string>

<!-- TODO: Remove or change this placeholder text -->
<string name="hello_map_fragment">Hello map fragment</string>
</resources>