Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Angle Brackets] Co-exist with non-Ember web components and "x-foo" named elements #11269

Closed
mike1o1 opened this issue May 25, 2015 · 8 comments

Comments

@mike1o1
Copy link

mike1o1 commented May 25, 2015

I have a number of HTML elements in my Ember addon that follow the web component naming convention, but aren't actual web components or Ember. They just plain HTML elements, and are named that way to make the html and stylesheets more readable and semantic, but the elements have no functionality aside from that.

I'm running into a number of errors, because Ember throws an error that "x-foo" component isn't found.

Can Ember perhaps throw a warning when this happens, instead of throwing an error? Or can Ember fall back to just creating a regular html element or skipping them?

@rwjblue
Copy link
Member

rwjblue commented May 25, 2015

It should fall back for registered elements. Are the ones in question registered?

@mike1o1
Copy link
Author

mike1o1 commented May 25, 2015

No, these are not registered with Ember as components. I was hoping to not have to create a number of "empty" Ember components with zero functionality.

@rwjblue
Copy link
Member

rwjblue commented May 25, 2015

This is definitely a thing we need to allow, but it will most likely be done via a whitelisting API. We have disabled the angle bracket component invocation feature (in #11267), and a new RFC (emberjs/rfcs#60) has been submitted to deal with many issues that were identified.

@krisselden
Copy link
Contributor

@rwjblue it should bind() to registered components, it should fallback if there is no ember or no registered components.

I personally consider angle bracket tags blocked until they fallback, I don't think it is reasonable for ember to assume ownership of all of them, or error on a failed lookup (we could flag for a team discussion but I know that @wycats and @ebryn have told me in the past that fallback was a requirement).

It is fine if we want to add a warning to lint typos that you can suppress with some declaration like /* global */ in js.

@krisselden
Copy link
Contributor

Actually, I'm not sure if Model Driven Views is a web component thing anymore, so ignore what I said about Node.bind()

@stefanpenner
Copy link
Member

Actually, I'm not sure if Model Driven Views is a web component thing anymore, so ignore what I said about Node.bind()

yes, I don't believe so.

@locks
Copy link
Contributor

locks commented Apr 15, 2016

Given the current state of the union, namely emberjs/rfcs#60 (comment), could this issue be closed?

@rwjblue
Copy link
Member

rwjblue commented Apr 15, 2016

Yes, closing for now. We will definitely have to readdress when we reintroduce angle bracket components.

@rwjblue rwjblue closed this as completed Apr 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants