Control Settings: remove 'placeholder' and 'title' settings from base settings #3795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… controls that actually use them
kobizz
approved these changes
Mar 18, 2018
ramiy
changed the title
placeholder and title settings to specific controls that actually use them
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
$_base_settingsproperty inBase_Controlholds the common settings relevant for all the controls (label,description,separator,label_block,show_label), but it also has two settings that are relevant to few very specific controls (title,placeholder). Those settings should be moved to those specific controls to theirget_default_settings()methods.