Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep screen on while recording voicebroadcast #8313

Merged
merged 3 commits into from
Apr 12, 2023

Conversation

yostyle
Copy link
Contributor

@yostyle yostyle commented Apr 6, 2023

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

When you start a recording it will stop when the display timeout is triggerd. We should have a wake lock in this case.

Motivation and context

Screenshots / GIFs

Tests

  • Step 1
  • Step 2
  • Step ...

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

@yostyle yostyle requested review from a team and Florian14 and removed request for a team April 6, 2023 17:14
@yostyle yostyle changed the title Keep screen on while recording podcast Keep screen on while recording a voicebroadcast Apr 6, 2023
@yostyle yostyle changed the title Keep screen on while recording a voicebroadcast Keep screen on while recording voicebroadcast Apr 6, 2023
@yostyle yostyle marked this pull request as ready for review April 6, 2023 17:20
@@ -103,6 +105,7 @@ class VoiceBroadcastRecorderQ(

override fun startRecord(roomId: String) {
super.startRecord(roomId)
playbackTracker.updateCurrentRecording(AudioMessagePlaybackTracker.RECORDING_ID, emptyList())
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should call playbackTracker.stopPlayback() when stopping the recording (it will change the playback state to IDLE) or rename the existing method/add a new one.

Eventually also call stopPlayback on pause & updateCurrentRecording on resume

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added the tracker on stop. I don't prefer to manage pause state for the moment.

@yostyle yostyle force-pushed the yostyle/keep_screenon_vb_recording branch from 3c6492a to baa64cc Compare April 12, 2023 09:32
@yostyle yostyle requested a review from Florian14 April 12, 2023 09:35
@yostyle yostyle force-pushed the yostyle/keep_screenon_vb_recording branch from baa64cc to 2506d95 Compare April 12, 2023 09:41
@yostyle yostyle enabled auto-merge (squash) April 12, 2023 09:42
@yostyle yostyle force-pushed the yostyle/keep_screenon_vb_recording branch from 2506d95 to b2cbffc Compare April 12, 2023 09:43
@sonarcloud
Copy link

sonarcloud bot commented Apr 12, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

5.3% 5.3% Coverage
0.0% 0.0% Duplication

Copy link
Contributor

@Florian14 Florian14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yostyle yostyle merged commit fb837fe into develop Apr 12, 2023
@yostyle yostyle deleted the yostyle/keep_screenon_vb_recording branch April 12, 2023 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants