Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Session manager] Missing info when a session does not support encryption #7853

Closed
mnaturel opened this issue Dec 28, 2022 · 0 comments · Fixed by #7854
Closed

[Session manager] Missing info when a session does not support encryption #7853

mnaturel opened this issue Dec 28, 2022 · 0 comments · Fixed by #7854
Assignees
Labels
A-Settings O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Something isn't working: bugs, crashes, hangs and other reported problems

Comments

@mnaturel
Copy link
Contributor

Steps to reproduce

  • Create a session that does not support encryption using the following command line:

curl -d '{ "type": "m.login.password", "identifier": { "type": "m.id.user", "user": "..." }, "password": "..." }' -H "Content-Type: application/json" -X POST https://matrix-client.matrix.org/_matrix/client/v3/login

  • Enable the new session manager in labs settings
  • Go to Settings -> Security & Privacy -> Show all sessions
  • Go to the other sessions list to find the new created session from command line
  • Press the item of this session

Outcome

What did you expect?

When a session does not support encryption, in the new session manager:

  • the session name should not be empty and should be the session ID in worst case scenario
  • session info is displayed in the session overview screen
  • session appears in the unverified sessions list

Also, when the last activity timestamp of a session is not known, it should not be considered as inactive.

What happened instead?

When a session does not support encryption, in the new session manager:

  • the session name is empty
  • there is no info displayed in the session overview screen
  • the session does not appear in the unverified sessions list whereas it is considered as unverified

Also, when the last activity timestamp of a session is not known, it is considered as inactive whereas we cannot say anything about the inactivity status of the session.

Your phone model

No response

Operating system version

No response

Application version and app store

No response

Homeserver

No response

Will you send logs?

No

Are you willing to provide a PR?

Yes

@mnaturel mnaturel added T-Defect Something isn't working: bugs, crashes, hangs and other reported problems S-Minor Impairs non-critical functionality or suitable workarounds exist O-Uncommon Most users are unlikely to come across this or unexpected workflow A-Settings labels Dec 28, 2022
@mnaturel mnaturel self-assigned this Dec 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Settings O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Something isn't working: bugs, crashes, hangs and other reported problems
Projects
None yet
1 participant