Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing translations on "replyTo" messages #7555

Closed
mnaturel opened this issue Nov 9, 2022 · 0 comments · Fixed by #7566
Closed

Missing translations on "replyTo" messages #7555

mnaturel opened this issue Nov 9, 2022 · 0 comments · Fixed by #7566
Assignees
@mnaturel
Labels
A-Timeline O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Something isn't working: bugs, crashes, hangs and other reported problems

Comments

@mnaturel
Copy link
Contributor

mnaturel commented Nov 9, 2022 •
edited
Loading

Steps to reproduce

When rendering "replyTo" text messages in the timeline of a room, the text messages are in English and not translated in the language set in preferences.

Outcome

What did you expect?

"ReplyTo" messages should be translated.

What happened instead?

"ReplyTo" messages are not translated.

To fix this, translation should happen on the app side (not in SDK side) when rendering "ReplyTo" messages.

Your phone model

No response

Operating system version

No response

Application version and app store

No response

Homeserver

No response

Will you send logs?

No

Are you willing to provide a PR?

Yes
@mnaturel mnaturel added T-Defect Something isn't working: bugs, crashes, hangs and other reported problems A-Timeline S-Minor Impairs non-critical functionality or suitable workarounds exist O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience labels Nov 9, 2022
@mnaturel mnaturel self-assigned this Nov 9, 2022
@mnaturel mnaturel mentioned this issue Nov 10, 2022
Merged
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mnaturel mnaturel

Labels
A-Timeline O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Something isn't working: bugs, crashes, hangs and other reported problems
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Missing translations on "replyTo" messages (PSG-978) element-hq/element-android
1 participant
@mnaturel