Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Element doesn't respect system font scaling #5687

Closed
thefirstofthe300 opened this issue Apr 4, 2022 · 7 comments
Closed

Element doesn't respect system font scaling #5687

thefirstofthe300 opened this issue Apr 4, 2022 · 7 comments
Assignees
Labels
A11y O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Something isn't working: bugs, crashes, hangs and other reported problems

Comments

@thefirstofthe300
Copy link
Contributor

Steps to reproduce

  1. Set system font size to any value (smallest for greatest contrast)
  2. Open Element and observe current font size
  3. Set system font size to another value (largest for greatest contrast
  4. Open Element and observe that the font sizes have stayed the same (with the notable exception of the chips used to denote @'ing someone

Outcome

Font sizes don't change

Your phone model

No response

Operating system version

No response

Application version and app store

No response

Homeserver

No response

Will you send logs?

No

@thefirstofthe300 thefirstofthe300 added the T-Defect Something isn't working: bugs, crashes, hangs and other reported problems label Apr 4, 2022
@bmarty bmarty added the A11y label Apr 5, 2022
@ericdecanini ericdecanini added S-Tolerable Low/no impact on users O-Uncommon Most users are unlikely to come across this or unexpected workflow labels Apr 11, 2022
@ericdecanini ericdecanini added S-Minor Impairs non-critical functionality or suitable workarounds exist and removed S-Tolerable Low/no impact on users labels Apr 11, 2022
@fedrunov fedrunov self-assigned this May 23, 2022
@fedrunov
Copy link
Contributor

We have currently app-wide setting to define font scale (Settings->Preferences->Font size) and the problem is that on app start we always set font scale for the app from that setting. So if system setting is the "largest" text scale but in-app setting is "normal", the resulting applying scale will be "normal", and if user change system setting we ignore it, applying only whatever set in the app settings. The only moment when we sync with system property is first start of the app.- we get system property and apply it to the app setting.

I think we should have "system default" setting as default one, until user manually change it to something specific in the app settings. If "system default" is set, app will use system settings, reflecting any changes in them. @daniellekirkwood what do you think?

This is how in-app font scale setting dialog look like now:
Screenshot 2022-05-24 at 12 18 43

@daniellekirkwood
Copy link
Contributor

Thanks, @fedrunov !!

Let's go ahead and add "Use system default" to the top of this list with a radio button. We'll use font size "Normal" for the label.

@fedrunov
Copy link
Contributor

Here how it looks like:

image

I think it would be better if list will contain only scale factor items and "use system default" will be on top as a checkbox. When it's checked list will be "readonly" and item, corresponding to system setting will be selected. When it's unchecked list will be interactive and user could select an option to override system setting for element.

@fedrunov
Copy link
Contributor

@niquewoodhouse, @amshakal what do you think?

@amshakal
Copy link

Hey! I agree with your solution, the only thing I'll add is a line seperating system default from the rest of the options. Happy to create a visual representation of it if needed.

@fedrunov
Copy link
Contributor

@amshakal thanks, I think it would be better if we'll have design in figma. I also think that this should be a full screen, since list doesn't fit dialog anymore and scroll in dialog is not a perfect solution

@germain-gg germain-gg added the X-Needs-Design May require input from the design team label May 31, 2022
@amshakal
Copy link

amshakal commented Jun 6, 2022

I have created a full screen interaction to choose font size. I have kept system default as a separate option, and when selected, the options below will be disabled. Let me know if this works. Figma link.
Screenshot 2022-06-06 at 19 39 26

@fedrunov fedrunov mentioned this issue Jul 7, 2022
14 tasks
@germain-gg germain-gg removed the X-Needs-Design May require input from the design team label Jul 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A11y O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Something isn't working: bugs, crashes, hangs and other reported problems
Projects
None yet
Development

No branches or pull requests

7 participants