Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes unread marker in item_room.xml #5294

Merged
merged 2 commits into from
Feb 22, 2022

Conversation

ericdecanini
Copy link
Contributor

@ericdecanini ericdecanini commented Feb 22, 2022

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other : Misc

Content

  • Unread marker colour changed from colorSecondary (green) to vctr_content_secondary (grey)

Motivation and context

iOS already uses this grey colour and we want to have parity with them

Screenshots / GIFs

Before After
Light beforelight afterlight
Dark beforedark afterdark

Tests

Go to Rooms tab
See that marker for rooms with unread messages is grey

Tested devices

  • Physical
  • Emulator
  • OS version(s): Android 10

Checklist

@github-actions
Copy link

Matrix SDK

Integration Tests Results:

  • [org.matrix.android.sdk.session]
    passed=
  • [org.matrix.android.sdk.account]
    passed=
  • [org.matrix.android.sdk.internal]
    passed=
  • [org.matrix.android.sdk.ordering]
    passed=
  • [org.matrix.android.sdk.PermalinkParserTest]
    passed=

@github-actions
Copy link

Unit Test Results

  84 files  ±0    84 suites  ±0   59s ⏱️ -1s
157 tests ±0  157 ✔️ ±0  0 💤 ±0  0 ±0 
504 runs  ±0  504 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit ff0b0f2. ± Comparison against base commit 116f7d0.

Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bmarty bmarty marked this pull request as ready for review February 22, 2022 13:27
@bmarty bmarty merged commit 6d45886 into develop Feb 22, 2022
@bmarty bmarty deleted the feature/eric/roomlist-green-to-grey branch February 22, 2022 13:27
@bmarty
Copy link
Member

bmarty commented Feb 22, 2022

Linked issue: #4639 (next time please add it to the PR description, thanks!)

@frandavid100
Copy link

I'm sorry, but why not use a small grey dot at the right side like Element Web does?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants