Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement improved rendering for threads in the main timeline #5151

Closed
janogarcia opened this issue Feb 4, 2022 · 4 comments · Fixed by #5688
Closed

Implement improved rendering for threads in the main timeline #5151

janogarcia opened this issue Feb 4, 2022 · 4 comments · Fixed by #5688
Assignees
Labels
A-Threads An issue for the Threads project T-Task Refactoring, enabling or disabling functionality, other engineering tasks Z-Labs

Comments

@janogarcia
Copy link

janogarcia commented Feb 4, 2022

Changelog

Root messages should form a standalone group with their respective thread summaries.

This way, we establish a clear relationship between the thread summary and the root message it belongs to. Failure to do it results in an ambiguous relationship that only gets worse when message bubbles are enabled.

Source

https://www.figma.com/file/T309ztx0sNyOOK6NKVLHsK/Threads?node-id=3085%3A305790

Snapshot

Threads – Figma

@janogarcia janogarcia added A-Threads An issue for the Threads project T-Task Refactoring, enabling or disabling functionality, other engineering tasks labels Feb 4, 2022
@github-actions github-actions bot added the Z-Labs label Feb 4, 2022
@janogarcia
Copy link
Author

I've updated the issue description and mockup for better clarity on what the expected rendering should be. 👍


Current implementation is close to it but not there yet.

The thread should have been rendered in a standalone group that doesn't include the fourth message.

Screenshot_20220425-123414

@janogarcia janogarcia reopened this Apr 25, 2022
@ariskotsomitopoulos
Copy link
Contributor

Thanks for pointing this out, now its much more clear

@novocaine
Copy link

@janogarcia please review and close if you're happy

@janogarcia
Copy link
Author

@ariskotsomitopoulos Hadn't worked for me so far. Updating to the latest Beta 1.4.16 (released yesterday) did the trick. Everything's looking fine now. Thanks! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Threads An issue for the Threads project T-Task Refactoring, enabling or disabling functionality, other engineering tasks Z-Labs
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants