Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update diagnostic callout message #191074

Merged
merged 9 commits into from
Aug 26, 2024
Merged

Update diagnostic callout message #191074

merged 9 commits into from
Aug 26, 2024

Conversation

jlind23
Copy link
Contributor

@jlind23 jlind23 commented Aug 22, 2024

Fixes #191073

@jlind23 jlind23 added the Team:Fleet Team label for Observability Data Collection Fleet team label Aug 22, 2024
@jlind23 jlind23 self-assigned this Aug 22, 2024
@jlind23 jlind23 requested a review from a team as a code owner August 22, 2024 12:48
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@obltmachine
Copy link

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@jlind23 jlind23 added the release_note:skip Skip the PR/issue when compiling release notes label Aug 22, 2024
@jlind23 jlind23 marked this pull request as draft August 22, 2024 12:51
@jlind23 jlind23 marked this pull request as ready for review August 22, 2024 12:52
@jlind23
Copy link
Contributor Author

jlind23 commented Aug 22, 2024

@kilfoyle happy to get your eyes on the copy :)

nchaulet
nchaulet approved these changes Aug 22, 2024
View reviewed changes
Copy link
Member

@nchaulet nchaulet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

kilfoyle
kilfoyle approved these changes Aug 22, 2024
View reviewed changes
Copy link
Contributor

@kilfoyle kilfoyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎸
Just a very slight suggested rephrasing.

jlind23 and others added 3 commits August 22, 2024 18:49
@jlind23 @kilfoyle
Update x-pack/plugins/fleet/public/applications/fleet/sections/agents…
a7c4ac7 
…/agent_details_page/components/agent_diagnostics/index.tsx

Co-authored-by: David Kilfoyle <41695641+kilfoyle@users.noreply.github.com>
@jlind23 @kilfoyle
Update x-pack/plugins/fleet/public/applications/fleet/sections/agents…
b8e38dc 
…/components/agent_request_diagnostics_modal/index.tsx

Co-authored-by: David Kilfoyle <41695641+kilfoyle@users.noreply.github.com>
@jlind23
Merge branch 'main' into jlind23-patch-1
a857dd7
@jlind23 jlind23 enabled auto-merge (squash) August 22, 2024 16:49
@jlind23
Copy link
Contributor Author

jlind23 commented Aug 26, 2024

@elasticmachine merge upstream

@jlind23
Copy link
Contributor Author

jlind23 commented Aug 26, 2024

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #57 / endpoint Endpoint permissions: when running with user/role [rule_author] should display endpoint data on Host Details

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
fleet 1.8MB 1.8MB +154.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @jlind23

@jlind23 jlind23 merged commit 2e131b2 into main Aug 26, 2024
22 checks passed
@jlind23 jlind23 deleted the jlind23-patch-1 branch August 26, 2024 17:40
@kibanamachine kibanamachine added v8.16.0 backport:skip This commit does not require backporting labels Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nchaulet nchaulet nchaulet approved these changes

@kilfoyle kilfoyle kilfoyle approved these changes

Assignees

@jlind23 jlind23

Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v8.16.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Fleet] Elastic Agent diagnostic collection
7 participants
@jlind23 @elasticmachine @obltmachine @kibana-ci @nchaulet @kilfoyle @kibanamachine