Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ILM- when the ILM form is invalid, no request should be sent hence there should be no toast. #129647

Open
rashmivkulkarni opened this issue Apr 6, 2022 · 3 comments
Open

ILM- when the ILM form is invalid, no request should be sent hence there should be no toast. #129647

rashmivkulkarni opened this issue Apr 6, 2022 · 3 comments
Labels
bug Fixes for quality problems that affect the customer experience Feature:ILM good first issue low hanging fruit Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more

Comments

@rashmivkulkarni
Copy link
Contributor

Kibana version: 8.2.0 BC1

If the ILM form is invalid no request should be sent to the host. The validation should show only one error message. I don't think the toast notification is necessary.
Screen Shot 2022-04-05 at 1 49 01 PM

cc @alisonelizabeth @yuliacech
@rashmivkulkarni rashmivkulkarni added bug Fixes for quality problems that affect the customer experience Feature:ILM Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more labels Apr 6, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/platform-deployment-management (Team:Deployment Management)

@alisonelizabeth alisonelizabeth removed the Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more label Sep 16, 2024
@botelastic botelastic bot added the needs-team Issues missing a team label label Sep 16, 2024
@alisonelizabeth alisonelizabeth added Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more and removed needs-team Issues missing a team label labels Sep 16, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-management (Team:Kibana Management)

@alisonelizabeth alisonelizabeth added the good first issue low hanging fruit label Sep 16, 2024
@alisonelizabeth
Copy link
Contributor

Agreed, let's remove the toast notification in this case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Fixes for quality problems that affect the customer experience Feature:ILM good first issue low hanging fruit Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@alisonelizabeth @rashmivkulkarni @elasticmachine