Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Reporting/Dev] Remove setup code for Remote Debugger - No longer using this feature #101233

Open
tsullivan opened this issue Jun 2, 2021 · 5 comments
Open

[Reporting/Dev] Remove setup code for Remote Debugger - No longer using this feature #101233

tsullivan opened this issue Jun 2, 2021 · 5 comments
Labels
bug Fixes for quality problems that affect the customer experience Feature:Reporting:Screenshot Reporting issues pertaining to PNG/PDF file export good first issue low hanging fruit impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience)

Comments

@tsullivan
Copy link
Member

tsullivan commented Jun 2, 2021 •
edited
Loading

Before upgrading Chromium to 8.0.0, a developer could see the screen of the headless browser when testing by adding:

xpack.reporting.capture.browsers.chromium.inspect: true

When the setting works, it shows the screen of the headless browser while a report is executing (screenshot from running 7.12 branch):
image

After upgrading, something broke in how this is supposed to work: it no longer shows anything:
image
@tsullivan tsullivan added bug Fixes for quality problems that affect the customer experience Team:AppServices labels Jun 2, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-reporting-services (Team:Reporting Services)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServices)

@tsullivan
Copy link
Member Author

Relevant Chrome DevTools Protocol documentation: https://chromedevtools.github.io/devtools-protocol/tot/Debugger/#method-enable

@tsullivan tsullivan mentioned this issue Jun 2, 2021
Closed
@tsullivan tsullivan changed the title [Reporting/Dev] Browser inspector is not showing the screen view [Reporting/Dev] Remote debugger is not connecting Browser inspector is not showing the screen view Jun 3, 2021
@tsullivan tsullivan changed the title [Reporting/Dev] Remote debugger is not connecting Browser inspector is not showing the screen view [Reporting/Dev] Remote debugger is not connecting Jun 3, 2021
@exalate-issue-sync exalate-issue-sync bot added impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. and removed impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. labels Jun 3, 2021
@exalate-issue-sync exalate-issue-sync bot added loe:medium Medium Level of Effort impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. and removed loe:small Small Level of Effort impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. labels Jul 8, 2021
@exalate-issue-sync exalate-issue-sync bot added impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. and removed impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. labels Dec 6, 2021
@exalate-issue-sync exalate-issue-sync bot added loe:small Small Level of Effort and removed loe:medium Medium Level of Effort labels Jun 3, 2022
@tsullivan tsullivan mentioned this issue Sep 8, 2022
Closed
3 tasks
@petrklapka petrklapka added (Deprecated) Feature:Reporting Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) and removed Team:AppServicesSv labels Oct 24, 2022
@tsullivan
Copy link
Member Author

Let's go ahead and remove the code tied to attaching to a remote debugger for development

@tsullivan tsullivan reopened this Feb 2, 2023
@tsullivan
Copy link
Member Author

We can leave this issue open to track the work to remove the remote debugger setup.

@tsullivan tsullivan added Feature:Reporting:Screenshot Reporting issues pertaining to PNG/PDF file export and removed (Deprecated) Feature:Reporting Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead labels Aug 1, 2024
@petrklapka petrklapka added the good first issue low hanging fruit label Sep 23, 2024
@petrklapka petrklapka changed the title [Reporting/Dev] Remote debugger is not connecting [Reporting/Dev] Remove setup code for Remote Debugger - No longer using this feature Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Fixes for quality problems that affect the customer experience Feature:Reporting:Screenshot Reporting issues pertaining to PNG/PDF file export good first issue low hanging fruit impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@tsullivan @legrego @elasticmachine @petrklapka