-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update new atributes guest perms #1422
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary
- Reordered and added new fields for
guest
role permission inpublic_producer.yaml
- Added new columns to
guest
role permission inpublic_stat.yaml
Review
Reviewed addition of new fields and reorganization in public_producer.yaml
and public_stat.yaml
. Verified new fields and ensured proper context and security.
- head_block_producer | ||
- head_block_time | ||
- health_status | ||
- id |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The column ordering here shows a reorganization of the fields for the guest
role permission. This reordering should be verified to ensure it matches the intended schema and permissions. Ensure newly added fields like is_active
, addresshash
, and fio_address
are intended and properly secured.
- nodes_summary | ||
- tps_all_time_high | ||
- transaction_history | ||
- unique_locations |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New columns last_round
, missed_blocks
, nodes_summary
, tps_all_time_high
, transaction_history
, and unique_locations
have been added to the guest
role permission. Verify these additions for correctness in context to guest permissions to ensure no sensitive data exposure is happening.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Update new atributes guest perms