Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/handle route locatization #1391

Merged
merged 28 commits into from
Nov 27, 2023
Merged

Feat/handle route locatization #1391

merged 28 commits into from
Nov 27, 2023

Conversation

Torresmorah
Copy link
Collaborator

@Torresmorah Torresmorah commented Nov 21, 2023

Create a route per language

What does this PR do?

  • Handle the locatization in the url and add a sitemap per language

  • Refactor the folders structure related with files languages and sitemaps

  • Add a simple script to update and generate the rest of sitemaps using the sitemap-en.xml as source

  • Add a component LocaleLink to add the language in the link, it should be use instead of the Link from react-router-dom

  • Replace the links with the new component

  • Modify language selector to be reachable and open it when is focused

  • Resolve Korean Version #1363

  • Resolve Chinese Version #1364

Steps to test

  1. Run the project locally
  2. Test change the language in any page
  3. The url must change
  4. Test the links

Screenshots

imagen
imagen

Language Selector

imagen

Copy link
Collaborator

@xavier506 xavier506 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xavier506 xavier506 merged commit d687b9b into dev Nov 27, 2023
4 checks passed
@xavier506 xavier506 deleted the feat/handle-route-locatization branch November 27, 2023 04:28
@Torresmorah Torresmorah removed the WIP Work In Progress label Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Chinese Version Korean Version
3 participants