Skip to content

Latest commit

 

History

History
87 lines (67 loc) · 3.65 KB

CONTRIBUTING.md

File metadata and controls

87 lines (67 loc) · 3.65 KB
Raw

Contributing to Ignite

If you are interested in contributing to Ignite, your contributions will fall into two categories:

  1. You want to propose a new feature and implement it
    • Post about your intended feature, and we shall discuss the design and implementation. Once we agree that the plan looks good, go ahead and implement it.
  2. You want to implement a feature or bug-fix for an outstanding issue
    • Look at the outstanding issues here: https://github.com/pytorch/ignite/issues.
    • Pick an issue and comment on the task that you want to work on this feature.
    • If you need more context on a particular issue, please ask and we shall provide.

In both cases, you will also need to code some tests to ensure the correct behaviour. We are using pytest to write our tests:

  • naming convention for files test_*.py, e.g. test_precision.py
  • naming of testing functions def test_*, e.g. def test_precision_on_random_data()

New code should be compatible with Python 3.X versions. Once you finish implementing a feature or bugfix and tests, please run lint checking and tests:

pre-commit

To ensure the codebase complies with a style guide, we use black and flake8 to format and check codebase for compliance with PEP8.

To automate the process, we have configured the repo with pre-commit hooks to use black to autoformat the staged files to ensure every commit complies with a style guide. This requires some setup, which is described below:

  1. Install pre-commit in your python environment.
  2. Run pre-commit install that configures a virtual environment to invoke black and flake8 on commits.
pip install pre-commit
pre-commit install
  1. When files are committed:
    • If the stages files are not compliant with black, black will autoformat the staged files. If this were to happen, files should be staged and committed again. See example code below.
    • If the staged files are not compliant with flake8, errors will be raised. These errors should be fixed and the files should be committed again. See example code below.
git add .
git commit -m "Added awesome feature"
# DONT'T WORRY IF ERRORS ARE RAISED.
# YOUR CODE IS NOT COMPLIANT WITH FLAKE8 or BLACK
# Fix any flake8 errors by following their suggestions
# black will automatically format the files so they might look different, but you'll need to stage the files again for committing
# After fixing any flake8 errors
git add .
git commit -m "Added feature"

Formatting Code without pre-commit

If you choose not to use pre-commit, you can take advantage of IDE extensions configured to black format or invoke black manually to format files and commit them.

pip install black
black .
# This should autoformat the files
git add .
git commit -m "....."

Run lint checking

flake8 ignite/ tests/ examples/

Run tests:

pytest tests/ -vvv

or tests with coverage (assuming installed pytest-cov):

py.test --cov ignite --cov-report term-missing

Send a PR

If everything is OK, please send a Pull Request to https://github.com/pytorch/ignite

If you are not familiar with creating a Pull Request, here are some guides:

Writing documentation

Ignite uses Google style for formatting docstrings. Length of line inside docstrings block must be limited to 80 characters to fit into Jupyter documentation popups.