[Bugfix] Fix UVA sampling with lazy feature slicing #3862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nv-dlasalle
approved these changes
Mar 18, 2022
nv-dlasalle
reviewed
Mar 23, 2022
BarclayII
added a commit
that referenced
this pull request
Mar 31, 2022
* fix uva sampling with features * fix * add is_listlike function to distinguish strings from sequence * fix Co-authored-by: nv-dlasalle <63612878+nv-dlasalle@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3847 .
@jermainewang I might need your opinion on the behavior addition on lazy feature slicing. Now if a graph is previously in CPU pinned memory and a subgraph (
sample_neighbors) is taken, the new graph's features will be on GPU. Previously it was on CPU. This further complicates the code inColumn.data.Need to run a regression test on this.
Also fixes #3861 .