Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] call g.is_homogenous instead of len(g.etypes) #3793

Merged
merged 2 commits into from
Mar 2, 2022

Conversation

Rhett-Ying
Copy link
Collaborator

Description

fix for #3767. when len(g.etypes)=1 and len(g.ntypes)=2, it fails to partition graph.

Checklist

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [$CATEGORY] (such as [NN], [Model], [Doc], [Feature]])
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage
  • Code is well-documented
  • To the best of my knowledge, examples are either not affected by this change,
    or have been fixed to be compatible with this change
  • Related issue is referred in this PR
  • If the PR is for a new model/paper, I've updated the example index here.

Changes

@dgl-bot
Copy link
Collaborator

dgl-bot commented Mar 2, 2022

To trigger regression tests:

  • @dgl-bot run [instance-type] [which tests] [compare-with-branch];
    For example: @dgl-bot run g4dn.4xlarge all dmlc/master or @dgl-bot run c5.9xlarge kernel,api dmlc/master

@VoVAllen
Copy link
Collaborator

VoVAllen commented Mar 2, 2022

is graph len(g.etypes)=1 and len(g.ntypes)=2 a heterogenous graph or a homogenous graph?

@Rhett-Ying
Copy link
Collaborator Author

is graph len(g.etypes)=1 and len(g.ntypes)=2 a heterogenous graph or a homogenous graph?

it's hetero according to current logic of g.is_homogeneous: return len(self.ntypes) == 1 and len(self.etypes) == 1

@Rhett-Ying Rhett-Ying merged commit 1d80d91 into dmlc:master Mar 2, 2022
@Rhett-Ying Rhett-Ying deleted the hetero_partition branch March 2, 2022 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants