Skip to content

Commit

Permalink
OPP: Remove doc style comments for internal routines
Browse files Browse the repository at this point in the history 
These were previously exposed outside of the OPP core and needed doc
style commenting. They aren't public now and don't need the same.

This fixes warnings generated for builds with `W=1`:

core.c:2105: warning: Function parameter or member 'opp_table' not described in '_opp_set_supported_hw'
core.c:2105: warning: Excess function parameter 'dev' description in '_opp_set_supported_hw'
core.c:2148: warning: Function parameter or member 'opp_table' not described in '_opp_set_prop_name'
core.c:2148: warning: Excess function parameter 'dev' description in '_opp_set_prop_name'
core.c:2189: warning: Function parameter or member 'opp_table' not described in '_opp_set_regulators'
core.c:2189: warning: Excess function parameter 'count' description in '_opp_set_regulators'
core.c:2293: warning: Function parameter or member 'opp_table' not described in '_opp_set_clknames'
core.c:2293: warning: Function parameter or member 'config_clks' not described in '_opp_set_clknames'
core.c:2391: warning: Function parameter or member 'opp_table' not described in '_opp_set_config_regulators_helper'
core.c:2455: warning: Function parameter or member 'opp_table' not described in '_opp_attach_genpd'
core.c:2682: warning: Function parameter or member 'token' not described in 'dev_pm_opp_clear_config'
core.c:2682: warning: Excess function parameter 'opp_table' description in 'dev_pm_opp_clear_config'

Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202309091558.x3JJrxFI-lkp@intel.com/
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
  • Loading branch information
@vireshk
vireshk committed Oct 6, 2023
1 parent a0242c8 commit cca14de
Showing 1 changed file with 7 additions and 72 deletions.
79 changes: 7 additions & 72 deletions drivers/opp/core.c
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2124,12 +2124,7 @@ int _opp_add_v1(struct opp_table *opp_table, struct device *dev,
return ret;
}

/**
* _opp_set_supported_hw() - Set supported platforms
* @dev: Device for which supported-hw has to be set.
* @versions: Array of hierarchy of versions to match.
* @count: Number of elements in the array.
*
/*
* This is required only for the V2 bindings, and it enables a platform to
* specify the hierarchy of versions it supports. OPP layer will then enable
* OPPs, which are available for those versions, based on its 'opp-supported-hw'
Expand All @@ -2152,14 +2147,6 @@ static int _opp_set_supported_hw(struct opp_table *opp_table,
return 0;
}

/**
* _opp_put_supported_hw() - Releases resources blocked for supported hw
* @opp_table: OPP table returned by _opp_set_supported_hw().
*
* This is required only for the V2 bindings, and is called for a matching
* _opp_set_supported_hw(). Until this is called, the opp_table structure
* will not be freed.
*/
static void _opp_put_supported_hw(struct opp_table *opp_table)
{
if (opp_table->supported_hw) {
Expand All @@ -2169,11 +2156,7 @@ static void _opp_put_supported_hw(struct opp_table *opp_table)
}
}

/**
* _opp_set_prop_name() - Set prop-extn name
* @dev: Device for which the prop-name has to be set.
* @name: name to postfix to properties.
*
/*
* This is required only for the V2 bindings, and it enables a platform to
* specify the extn to be used for certain property names. The properties to
* which the extension will apply are opp-microvolt and opp-microamp. OPP core
Expand All @@ -2191,14 +2174,6 @@ static int _opp_set_prop_name(struct opp_table *opp_table, const char *name)
return 0;
}

/**
* _opp_put_prop_name() - Releases resources blocked for prop-name
* @opp_table: OPP table returned by _opp_set_prop_name().
*
* This is required only for the V2 bindings, and is called for a matching
* _opp_set_prop_name(). Until this is called, the opp_table structure
* will not be freed.
*/
static void _opp_put_prop_name(struct opp_table *opp_table)
{
if (opp_table->prop_name) {
Expand All @@ -2207,12 +2182,7 @@ static void _opp_put_prop_name(struct opp_table *opp_table)
}
}

/**
* _opp_set_regulators() - Set regulator names for the device
* @dev: Device for which regulator name is being set.
* @names: Array of pointers to the names of the regulator.
* @count: Number of regulators.
*
/*
* In order to support OPP switching, OPP layer needs to know the name of the
* device's regulators, as the core would be required to switch voltages as
* well.
Expand Down Expand Up @@ -2274,10 +2244,6 @@ static int _opp_set_regulators(struct opp_table *opp_table, struct device *dev,
return ret;
}

/**
* _opp_put_regulators() - Releases resources blocked for regulator
* @opp_table: OPP table returned from _opp_set_regulators().
*/
static void _opp_put_regulators(struct opp_table *opp_table)
{
int i;
Expand Down Expand Up @@ -2309,11 +2275,7 @@ static void _put_clks(struct opp_table *opp_table, int count)
opp_table->clks = NULL;
}

/**
* _opp_set_clknames() - Set clk names for the device
* @dev: Device for which clk names is being set.
* @names: Clk names.
*
/*
* In order to support OPP switching, OPP layer needs to get pointers to the
* clocks for the device. Simple cases work fine without using this routine
* (i.e. by passing connection-id as NULL), but for a device with multiple
Expand Down Expand Up @@ -2397,10 +2359,6 @@ static int _opp_set_clknames(struct opp_table *opp_table, struct device *dev,
return ret;
}

/**
* _opp_put_clknames() - Releases resources blocked for clks.
* @opp_table: OPP table returned from _opp_set_clknames().
*/
static void _opp_put_clknames(struct opp_table *opp_table)
{
if (!opp_table->clks)
Expand All @@ -2412,11 +2370,7 @@ static void _opp_put_clknames(struct opp_table *opp_table)
_put_clks(opp_table, opp_table->clk_count);
}

/**
* _opp_set_config_regulators_helper() - Register custom set regulator helper.
* @dev: Device for which the helper is getting registered.
* @config_regulators: Custom set regulator helper.
*
/*
* This is useful to support platforms with multiple regulators per device.
*
* This must be called before any OPPs are initialized for the device.
Expand All @@ -2431,13 +2385,6 @@ static int _opp_set_config_regulators_helper(struct opp_table *opp_table,
return 0;
}

/**
* _opp_put_config_regulators_helper() - Releases resources blocked for
* config_regulators helper.
* @opp_table: OPP table returned from _opp_set_config_regulators_helper().
*
* Release resources blocked for platform specific config_regulators helper.
*/
static void _opp_put_config_regulators_helper(struct opp_table *opp_table)
{
if (opp_table->config_regulators)
Expand All @@ -2463,12 +2410,7 @@ static void _detach_genpd(struct opp_table *opp_table)
opp_table->genpd_virt_devs = NULL;
}

/**
* _opp_attach_genpd - Attach genpd(s) for the device and save virtual device pointer
* @dev: Consumer device for which the genpd is getting attached.
* @names: Null terminated array of pointers containing names of genpd to attach.
* @virt_devs: Pointer to return the array of virtual devices.
*
/*
* Multiple generic power domains for a device are supported with the help of
* virtual genpd devices, which are created for each consumer device - genpd
* pair. These are the device structures which are attached to the power domain
Expand Down Expand Up @@ -2544,13 +2486,6 @@ static int _opp_attach_genpd(struct opp_table *opp_table, struct device *dev,

}

/**
* _opp_detach_genpd() - Detach genpd(s) from the device.
* @opp_table: OPP table returned by _opp_attach_genpd().
*
* This detaches the genpd(s), resets the virtual device pointers, and puts the
* OPP table.
*/
static void _opp_detach_genpd(struct opp_table *opp_table)
{
/*
Expand Down Expand Up @@ -2702,7 +2637,7 @@ EXPORT_SYMBOL_GPL(dev_pm_opp_set_config);

/**
* dev_pm_opp_clear_config() - Releases resources blocked for OPP configuration.
* @opp_table: OPP table returned from dev_pm_opp_set_config().
* @token: The token returned by dev_pm_opp_set_config() previously.
*
* This allows all device OPP configurations to be cleared at once. This must be
* called once for each call made to dev_pm_opp_set_config(), in order to free
Expand Down

0 comments on commit cca14de

Please sign in to comment.