Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed in d3v6, d3.mouse is used by BubbleOverlay.debug #1807

Closed
kum-deepak opened this issue Jan 16, 2021 · 5 comments · Fixed by #1808
Closed

Removed in d3v6, d3.mouse is used by BubbleOverlay.debug #1807

kum-deepak opened this issue Jan 16, 2021 · 5 comments · Fixed by #1808
Labels
dc-v5
Milestone
dc-v5

Comments

@kum-deepak
Copy link
Collaborator

kum-deepak commented Jan 16, 2021 •
edited
Loading

This is not a commonly used option, so, it did not get detected earlier. It is possible to write a compat (new method d3.pointer). This needs to be applied to both dc v4 and v5.
@kum-deepak kum-deepak changed the title Deprecated d3v6 d3.mouse is used by BubbleOverlay.debug Removed in d3v6, d3.mouse is used by BubbleOverlay.debug Jan 16, 2021
@kum-deepak kum-deepak mentioned this issue Jan 16, 2021
Merged
@kum-deepak
Copy link
Collaborator Author

Need same change in dc-v5 branch.

@kum-deepak kum-deepak added this to the dc-v5 milestone Jan 16, 2021
@gordonwoodhull
Copy link
Contributor

gordonwoodhull commented Feb 15, 2021 •
edited
Loading

Pretty obscure!

According to 8a7de3c this debug feature is #52 and the idea is that you can use debug mode to get coordinates for your bubbles by hovering over the map. Bubble coordinates are specified one by one with BubbleOverlay.point() in pixel coordinates.

Screen Shot 2021-02-15 at 2 18 52 AM

@gordonwoodhull
Copy link
Contributor

gordonwoodhull commented Feb 15, 2021 •
edited
Loading

Interesting, looks like GitHub will now close an issue if a comment on a merged PR says "fixes #xxx" - this only used to work for commit messages.

Reopening for dc-v5; @kum-deepak, please apply the change at your convenience.

@kum-deepak
Copy link
Collaborator Author

Good to see you active again. It had started feeling very lonely 😄

@kum-deepak kum-deepak mentioned this issue Oct 29, 2021
Merged
@kum-deepak
Copy link
Collaborator Author

Covered in #1847 for dc@v5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dc-v5
Projects
None yet
Milestone
dc-v5
Development

Successfully merging a pull request may close this issue.

d3v6 compat, d3.mouse vs d3.pointer dc-js/dc.js
2 participants
@gordonwoodhull @kum-deepak