Skip to content
This repository has been archived by the owner on May 6, 2024. It is now read-only.

stop using system site package #161

Merged
merged 5 commits into from
Aug 19, 2022
Merged

stop using system site package #161

merged 5 commits into from
Aug 19, 2022

Conversation

ChenyuLInx
Copy link
Contributor

@ChenyuLInx ChenyuLInx commented Aug 18, 2022

resolves #160 #159
Based on suggestions from @kyleries

Description

This would stop use system site package. It will make sure install succeed but slowdown the installation.

After this change merged I see no issue install via brew locally, just the GHA is still failing

Checklist

  • I have signed the CLA
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR

@cla-bot cla-bot bot added the cla:yes label Aug 18, 2022
@ChenyuLInx ChenyuLInx marked this pull request as draft August 18, 2022 22:49
@ChenyuLInx
Copy link
Contributor Author

Testing the changes here

@@ -287,7 +287,7 @@ class DbtBigqueryAT120 < Formula

def install
ENV["CARGO_NET_GIT_FETCH_WITH_CLI"] = "true"
venv = virtualenv_create(libexec, "python3")
venv = virtualenv_create(libexec, "python3", system_site_packages: false) system_site_packages: false)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a duplicate entry here

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like it's happening in a couple places just FYI

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea I just did everything locally again, not sure what happened during find/replace

@@ -228,7 +228,7 @@ class DbtPostgresAT107 < Formula

def install
ENV["CARGO_NET_GIT_FETCH_WITH_CLI"] = "true"
venv = virtualenv_create(libexec, "python3")
venv = virtualenv_create(libexec, "python3", system_site_packages: false) system_site_packages: false)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same

@ChenyuLInx
Copy link
Contributor Author

ChenyuLInx commented Aug 18, 2022

@leahwicz are the installation tests only run on main branch? Asking since the fix apparently works locally but didn't work for the test run here

@leahwicz
Copy link
Contributor

The tests only run on the published formulas so we have to just commit these and then run the tests

@leahwicz
Copy link
Contributor

I'm ok with committing this and seeing if the fix works since we have the local testing passing

@ChenyuLInx ChenyuLInx marked this pull request as ready for review August 19, 2022 18:13
@ChenyuLInx ChenyuLInx merged commit eab96ff into main Aug 19, 2022
@ChenyuLInx ChenyuLInx deleted the fix/install-broken branch August 19, 2022 18:13
@kyleries
Copy link

🤔 Hrm, appears the build is still failing, though with a slightly different (albeit likely related) error. Perhaps we can add an "on failure" hook to the action to post the contents of the full error log message for us. Alternatively, we could run the brew install command w/ the verbose flag if the env is CI. The full contents of that log will be much more helpful for us than just the last 15 lines we get a sneak peek at by default. I have a few meetings this afternoon for my #dayjob, but perhaps I can tackle that this evening/weekend.

@kyleries kyleries mentioned this pull request Aug 19, 2022
@kyleries
Copy link

I'm ok with committing this and seeing if the fix works since we have the local testing passing

@leahwicz - 👋 hello! I was just chatting w/ @ChenyuLInx in Slack about this since we're still seeing the GitHub Actions tests failing. I was observing some differences in behavior w/ the local act environment relative to the GitHub Actions env (not sure whether the runner or the images were the cause). Anywho - I decided to push my branch up to GitHub in order to run the tests in the GitHub Actions environment (see image below). That also afforded me the ability to test against macOS-latest which GitHub provides, but that I have not seen available via act. Anywho - I think perhaps I will write up a new issue to document my experiences contributing to this project, maybe starting w/ some README updates.

Anywho - thanks for the attention to this issue! ❤️

Screen Shot 2022-08-19 at 12 41 45 PM

@ChenyuLInx
Copy link
Contributor Author

@kyleries Thanks for the writeup!! I created #162 to add more logs, if you want to review it we can merge it into main and get more log there.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CT-1055] [Bug] brew install dbt-redshift fails on new M1 MacBook Pro
3 participants