Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

consider making dart_api_dl.cc a pure C file #42982

Closed
mraleph opened this issue Aug 7, 2020 · 3 comments
Closed

consider making dart_api_dl.cc a pure C file #42982

mraleph opened this issue Aug 7, 2020 · 3 comments
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. library-ffi

Comments

@mraleph
Copy link
Member

mraleph commented Aug 7, 2020

Currently it is a C++ file - which makes it impossible to reuse it in languages which allow simple consumption of C code (e.g. Go).
@mraleph mraleph added area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. library-ffi labels Aug 7, 2020
@mraleph
Copy link
Member Author

mraleph commented Aug 7, 2020

I made an example of making it a pure C file here: https://github.com/mraleph/go_dart_ffi_example/blob/master/dart_api_dl/include/dart_api_dl.c - so maybe we should just land it unless there is any opposition.

/cc @dcharkes

@dcharkes
Copy link
Contributor

sgtm

@dcharkes
Copy link
Contributor

@mraleph, I adapted your solution to https://dart-review.googlesource.com/c/sdk/+/157965.

@joe-getcouragenow joe-getcouragenow mentioned this issue Sep 4, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. library-ffi
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mraleph @dcharkes