Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Future.wait doesn't give time to callers to install error-handlers. #27249

Closed
floitschG opened this issue Sep 5, 2016 · 1 comment
Closed
Assignees
Labels
area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. library-async

Comments

@floitschG
Copy link
Contributor

https://codereview.chromium.org/2311923002/

@floitschG floitschG added area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. library-async labels Sep 5, 2016
@floitschG floitschG self-assigned this Sep 5, 2016
@lrhn
Copy link
Member

lrhn commented Sep 6, 2016

To be honest, I wouldn't mind if this case threw an error synchronously. It's an error in either iteration or calling Future.then and that just shouldn't happen. If it does happen, the error does not come from any of the futures, so putting it into the result future could be a little confusing.

On the other hand, having asynchronous functions report all their errors in the returned future seems to make some people happy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. library-async
Projects
None yet
Development

No branches or pull requests

2 participants