-
Notifications
You must be signed in to change notification settings - Fork 123
Meta issue: Expose our SASS theming API to end-users #45
Comments
My proposal at the moment: Phase 0Include the common sass files (things like the Material Design constants) in the repo. Users can clone them and use the styles to match the styles of custom components they create. Phase 1I am currently planning on adding the sass files to this repo and the pub package. Users will need a version of sass installed to build the package. Importing one of the included scss files in custom user created scss file would require getting the path of the package fetched by Alternatively they could be imported by cloning the repo and importing the file. This solution is not ideal since versions of the cloned repo and the package retrieved with pub get would not be guaranteed to be in sync. Phase 2Sass support with the knowledge of pub package URIs is coming when running in "Dart Mode". sass/dart-sass#19 I am currently investigating if the pre 1.0 release of Dart Sass supports all of the features exercised with our scss files. Once we have full support, we can release the scss files in the pub package and users should be able to import the scss files with package URIs. |
+1 I think getting the Sass files out there is beneficial even if the experience isn't great in using them. Right now people are largely in the dark with regards to how it is working, and the direction. Even if they can't use it they can at least see what is going on. |
@nshahan Are there any updates on this? I am really eager towards using Dart on a few projects, specifically with this package, and this issue is a blocker for me. |
Thanks for the ping. It is a good reminder that I should at least push the .scss files containing the functions and constants that are used across all components. I focus on getting that done. Most of this work got put to the side as I have been working on reorganizing our internal repo to support better syncing with github. I've spent some time trying to get the sass compiled when running |
Also sass/dart-sass#19 was fixed recently. |
Hi, First, thanks for the awesome work with dart, angular2 and angular_components 🎯. I would like to know if there are any update on this? Thanks in advance! 🎉 |
I am going to be adding all of our After that we can work on getting them used as part of the build process and we can removed pre-generated |
Oh hey... this is done and working. I forgot to close the issue. Some instructions to get started are in the README. |
No description provided.
The text was updated successfully, but these errors were encountered: