Only inject inputAccessoryView if textView isEditable. #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plu
changed the title
danielamitay
added a commit
that referenced
this pull request
May 26, 2014
Only inject inputAccessoryView if textView isEditable.
|
Thanks 👍 |
|
No, thank you! |
|
Thanks to both of you; this solves an issue I have with UITextViews in a UICollectionView and HPGrowingTextView. Will you be updating the podspec soon, or I shall I just point mine at master for the time being? |
|
I will update the podspec over the weekend 👍 |
|
Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a bug in UIKit that would fire a
UIKeyboard(Will|Did)ShowNotificationwhen aUITextViewis readonly (textView.editable = NO;) but has ainputAccessoryView. See also: http://openradar.appspot.com/radar?id=5306932189462528To work around this issue,
DAKeyboardControlshould only inject ainputAccessoryViewif theUITextViewactuallyisEditable.