Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn off videoCompression by default #26160

Closed
jennifer-shehane opened this issue Mar 20, 2023 · 4 comments
Closed

Turn off videoCompression by default #26160

jennifer-shehane opened this issue Mar 20, 2023 · 4 comments
Assignees
Labels
type: breaking change Requires a new major release version

Comments

@jennifer-shehane
Copy link
Member

What would you like?

Cypress also automatically compresses the recorded video to a Constant Rate Factor (CRF) of 32. Cypress could turn off video compression by default for all users - having a videoCompression value set to false in their configuration file.

Why is this needed?

Recording video in low CPU resourced machines results in slower runtime of Cypress tests. Video compression is on my default and blocking, so it increases the time the tests take to run. And video compression takes longer the longer the video is, so these reasons are compounding the problem.

Other

Turning off video compression would result in larger video sizes, which still needs exploration as to the impact for users and Cypress.

The release and implementation strategy has not been decided, but this could result in a breaking change for users.

@csvan
Copy link

csvan commented Mar 22, 2023

Would be amazing if this could be revisited while on the topic of video: #21976

@jennifer-shehane
Copy link
Member Author

jennifer-shehane commented May 3, 2023

We have decided to have videoCompression set to false for all users by default. This will go out in a breaking change (v13 likely).

In looking at this issue, we also fixed a bug where setting videoCompression: 0 would result in broken videos here.

We also intend to fix this issue where the video location doesn't print when video compression is skipped, since this situation would apply to all users now. See issue

We will also update the wording of what is printed to the terminal to say 'Compressing' instead of 'Processing' in the video terminal output. See issue.

We'll also add a 'true' value to videoCompression which coerces the value to 32 CRF. See issue.

@jennifer-shehane
Copy link
Member Author

The code for this is done, but this has yet to be released. We'll update this issue and reference the changelog when it's released.

@jennifer-shehane
Copy link
Member Author

Released in Cypress 13.0.0.

@cypress-io cypress-io locked as resolved and limited conversation to collaborators Aug 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: breaking change Requires a new major release version
Projects
Status: Generally Available
Development

No branches or pull requests

4 participants