Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Public API for Component Testing Onboarding #25638

Closed
lmiller1990 opened this issue Jan 30, 2023 · 11 comments · Fixed by #25780
Closed

Implement Public API for Component Testing Onboarding #25638

lmiller1990 opened this issue Jan 30, 2023 · 11 comments · Fixed by #25780

Comments

@lmiller1990
Copy link
Contributor

lmiller1990 commented Jan 30, 2023

What would you like?

Based on the work done in the technical brief: #24991 (Cypress team only), implement the proposed public API.

Documentation: (public post 12.7 release): https://docs.cypress.io/guides/component-testing/third-party-definitions

Why is this needed?

No response

Other

No response

@baus
Copy link
Collaborator

baus commented Jan 31, 2023

Please add your planning poker estimate with Zenhub @astone123

@baus
Copy link
Collaborator

baus commented Jan 31, 2023

Please add your planning poker estimate with Zenhub @lmiller1990

@baus
Copy link
Collaborator

baus commented Jan 31, 2023

Please add your planning poker estimate with Zenhub @marktnoonan

@baus
Copy link
Collaborator

baus commented Jan 31, 2023

Please add your planning poker estimate with Zenhub @mike-plummer

@baus
Copy link
Collaborator

baus commented Jan 31, 2023

Please add your planning poker estimate with Zenhub @warrensplayer

@baus
Copy link
Collaborator

baus commented Jan 31, 2023

Please add your planning poker estimate with Zenhub @ZachJW34

@astone123
Copy link
Contributor

@lmiller1990 Does this include reworking the existing adapters to use the API?

@lmiller1990
Copy link
Contributor Author

lmiller1990 commented Feb 1, 2023

Yeah it does - this single ticket will manage all the work, I don't think it's too large for a single PR. Reworking them should not be much work - the actual API/format isn't changing for internal adapters. Most of the work will be around grabbing a third party one (via cypress-ct-*) exposing the right exports, and integrating it to the workflow.

I wonder if we should stop naming things WIZARD and install call them something more generic. WIZARD is an internal implementation detail. Worth doing if it's not much work as part of this PR.

@lmiller1990
Copy link
Contributor Author

@lmiller1990
Copy link
Contributor Author

I'm removing this from the sprint in favor or the above two tickets. I split the points here between the two tickets.

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Feb 25, 2023

Released in 12.7.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v12.7.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Feb 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants