Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Search should ignore dashes or spaces #25303

Closed
Pashozator opened this issue Dec 29, 2022 · 10 comments · Fixed by #28012
Closed

Search should ignore dashes or spaces #25303

Pashozator opened this issue Dec 29, 2022 · 10 comments · Fixed by #28012
Labels
CT Issue related to component testing good first issue Good for newcomers Triaged Issue has been routed to backlog. This is not a commitment to have it prioritized by the team. type: regression A bug that didn't appear until a specific Cy version release v10.0.0 🐛 Issue present since 10.0.0

Comments

@Pashozator
Copy link
Contributor

What would you like?

Tests files are often name with "-" or "_" between words like "products-details" or "products_details". Search specs bar should be able to find those when you type "products details".

Why is this needed?

I want this because it will be a lot easier to find desire specs.

Other

No response
@emilyrohrbough emilyrohrbough added help wanted type: regression A bug that didn't appear until a specific Cy version release CT Issue related to component testing v10.0.0 🐛 Issue present since 10.0.0 labels Jan 4, 2023
@emilyrohrbough emilyrohrbough self-assigned this Jan 4, 2023
@emilyrohrbough emilyrohrbough added type: regression A bug that didn't appear until a specific Cy version release v10.0.0 🐛 Issue present since 10.0.0 and removed type: regression A bug that didn't appear until a specific Cy version release v10.0.0 🐛 Issue present since 10.0.0 labels Jan 4, 2023
@emilyrohrbough emilyrohrbough removed their assignment Jan 4, 2023
@nilgaar
Copy link
Contributor

nilgaar commented Jan 16, 2023

I can take care of this @emilyrohrbough

@Pashozator
Copy link
Contributor Author

@nilgaar how is going?

@nilgaar
Copy link
Contributor

nilgaar commented Jan 27, 2023

I'm waiting for the confirmation from @emilyrohrbough to start with this... Guess I can wait until next week for it, otherwise I'll just go for it.

@Pashozator
Copy link
Contributor Author

@nilgaar no need to hesitate I guess

@nagash77 nagash77 added Triaged Issue has been routed to backlog. This is not a commitment to have it prioritized by the team. and removed routed-to-ct labels Apr 19, 2023
@Pashozator
Copy link
Contributor Author

anything? @nilgaar

@Pashozator
Copy link
Contributor Author

@nagash77 anything on this issue?

@nilgaar nilgaar mentioned this issue Aug 20, 2023
Closed
3 tasks
@jennifer-shehane
Copy link
Member

We're open to accept a pull request for this, including proper tests around it.

@jennifer-shehane jennifer-shehane added good first issue Good for newcomers and removed help wanted labels Oct 4, 2023
@janlengyel
Copy link
Contributor

Hello, can I try to work on this issue? I see there was some work done already. Are the tests the only thing missing in the previous PR?

This is my first contribution, is there anything in particular I should be aware of (other than reading CONTRIBUTING.md)?

@janlengyel janlengyel mentioned this issue Oct 9, 2023
Merged
1 task
@janlengyel
Copy link
Contributor

@jennifer-shehane Can you please have a look at the PR?

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Oct 24, 2023

Released in 13.3.3.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v13.3.3, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Oct 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CT Issue related to component testing good first issue Good for newcomers Triaged Issue has been routed to backlog. This is not a commitment to have it prioritized by the team. type: regression A bug that didn't appear until a specific Cy version release v10.0.0 🐛 Issue present since 10.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: ignore dash, underscore and space in search janlengyel/cypress
6 participants
@nagash77 @jennifer-shehane @emilyrohrbough @Pashozator @janlengyel @nilgaar