Cucumber::Formatter::Interceptor::Pipe is not treated as an IO by ruby's built-in Logger

[rsutphin]

If you run Cucumber with the JUnit formatter enabled on an application which has code like the following:

Logger.new($stderr)

You will get an exception like this:

can't convert Cucumber::Formatter::Interceptor::Pipe into String
/Users/rsutphin/.rvm/rubies/ruby-1.9.3-p194/lib/ruby/1.9.1/logger.rb:592:in `open'
/Users/rsutphin/.rvm/rubies/ruby-1.9.3-p194/lib/ruby/1.9.1/logger.rb:592:in `open_logfile'
/Users/rsutphin/.rvm/rubies/ruby-1.9.3-p194/lib/ruby/1.9.1/logger.rb:549:in `initialize'
/Users/rsutphin/.rvm/rubies/ruby-1.9.3-p194/lib/ruby/1.9.1/logger.rb:314:in `new'
/Users/rsutphin/.rvm/rubies/ruby-1.9.3-p194/lib/ruby/1.9.1/logger.rb:314:in `initialize'

Ruby's built in logger uses this check to determine if a passed in object is an IO:

if log.respond_to?(:write) and log.respond_to?(:close)

Pipe has a write method, so adding a no-op Cucumber::Formatter::Interceptor::Pipe#close method might work around this problem.

[mattwynne]

On 7 Sep 2012, at 22:58, Rhett Sutphin wrote:

If you run Cucumber with the JUnit formatter enabled on an application which has code like the following:

Logger.new($stderr)
You will get an exception like this:

can't convert Cucumber::Formatter::Interceptor::Pipe into String
/Users/rsutphin/.rvm/rubies/ruby-1.9.3-p194/lib/ruby/1.9.1/logger.rb:592:in open' /Users/rsutphin/.rvm/rubies/ruby-1.9.3-p194/lib/ruby/1.9.1/logger.rb:592:inopen_logfile'
/Users/rsutphin/.rvm/rubies/ruby-1.9.3-p194/lib/ruby/1.9.1/logger.rb:549:in initialize' /Users/rsutphin/.rvm/rubies/ruby-1.9.3-p194/lib/ruby/1.9.1/logger.rb:314:innew'
/Users/rsutphin/.rvm/rubies/ruby-1.9.3-p194/lib/ruby/1.9.1/logger.rb:314:in `initialize'
Ruby's built in logger uses this check to determine if a passed in object is an IO:

if log.respond_to?(:write) and log.respond_to?(:close)
Pipe has a write method, so adding a no-op Cucumber::Formatter::Interceptor::Pipe#close method might work around this problem.

—
Reply to this email directly or view it on GitHub.

Thanks for figuring this out. Do you think you put together a pull request with a failing integration test for this? It's much more likely to get fixed that way.

[mattwynne]

Actually I think the Interceptor::Pipe should be delegating respond_to properly, that's the real problem.

[mattwynne]

Are we going to get a PR for this? 😄

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.