fix(panel): fix missing calculation on hiding #135

crimx · Jun 8, 2018 · bb5823e · bb5823e
1 parent 601852f
commit bb5823e
Showing 1 changed file with 10 additions and 12 deletions.
diff --git a/src/content/redux/modules/widget.ts b/src/content/redux/modules/widget.ts
@@ -599,18 +599,16 @@ function listenNewSelection (
       bowlRect,
     }
 
-    if (!isPinned) {
-      newWidgetPartial.panelRect = shouldPanelShow
-        ? _getPanelRectFromEvent(
-          mouseX,
-          mouseY,
-          lastPanelRect.width,
-          30 + state.dictionaries.active.length * 30,
-        )
-        : {
-          ...lastPanelRect,
-          height: isSaladictPopupPage ? 400 : 30,
-        }
+    if (!isPinned && (shouldPanelShow || !lastShouldPanelShow)) {
+      // don't calculate on hiding to prevent moving animation
+      newWidgetPartial.panelRect = _getPanelRectFromEvent(
+        mouseX,
+        mouseY,
+        lastPanelRect.width,
+        shouldPanelShow
+          ? 30 + state.dictionaries.active.length * 30
+          : isSaladictPopupPage ? 400 : 30,
+      )
     }
 
     dispatch(newSelection(newWidgetPartial))