fix: ignore numbers

crimx · Oct 19, 2019 · 352a84c · 352a84c
1 parent a95edfe
commit 352a84c
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 5 deletions.
diff --git a/src/_helpers/lang-check.ts b/src/_helpers/lang-check.ts
@@ -69,7 +69,7 @@ const isContain: { [key in Languages]: (text: string) => boolean } = {
 }
 
 const matcherPunct = /[/[\]{}$^*+|?.\-~!@#%&()_='";:><,。？！，、；：“”﹃﹄「」﹁﹂‘’『』（）—［］〔〕【】…－～·‧《》〈〉﹏＿]/
-const matchAllPunct = new RegExp(`^${matcherPunct.source}+$`)
+const matchAllMeaningless = new RegExp(`^(\\d|\\s|${matcherPunct.source})+$`)
 
 const matcherCJK = new RegExp(
   `${matchers.chinese.source}|${matchers.japanese.source}|${matchers.korean.source}`
@@ -103,7 +103,7 @@ export function checkSupportedLangs(
   }
 
   if (langs.matchAll) {
-    if (matchAllPunct.test(text)) {
+    if (matchAllMeaningless.test(text)) {
       return false
     }
 
@@ -149,7 +149,7 @@ export function checkSupportedLangs(
       return true
     }
 
-    if (!langs.others || matchAllPunct.test(text)) {
+    if (!langs.others || matchAllMeaningless.test(text)) {
       return false
     }
 

diff --git a/test/specs/_helpers/lang-check.spec.ts b/test/specs/_helpers/lang-check.spec.ts
@@ -49,11 +49,14 @@ describe('Language Check', () => {
     describe('with matchAll on', () => {
       const tl = tlHelper(true)
 
-      it('should return false with all punctuation', () => {
+      it('should return false with all meaningless characters', () => {
         expect(tl('。「')).toBe(false)
         expect(tl('。「', 'chinese')).toBe(false)
         expect(tl('。「', 'english')).toBe(false)
         expect(tl('。「', 'others')).toBe(false)
+        expect(tl('1234')).toBe(false)
+        expect(tl('1234', 'chinese')).toBe(false)
+        expect(tl('1234', 'others')).toBe(false)
       })
 
       it('should work with CJK', () => {
@@ -96,11 +99,14 @@ describe('Language Check', () => {
     describe('with matchAll off', () => {
       const tl = tlHelper(false)
 
-      it('should return false with all punctuation', () => {
+      it('should return false with all meaningless characters', () => {
         expect(tl('。「')).toBe(false)
         expect(tl('。「', 'chinese')).toBe(false)
         expect(tl('。「', 'english')).toBe(false)
         expect(tl('。「', 'others')).toBe(false)
+        expect(tl('1')).toBe(false)
+        expect(tl('1', 'english')).toBe(false)
+        expect(tl('1', 'others')).toBe(false)
       })
 
       it('should work with CJK', () => {