-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: add tests validating use of ROWOFFSET/ROWPARTITION user columns #7770
test: add tests validating use of ROWOFFSET/ROWPARTITION user columns #7770
Conversation
@confluentinc It looks like @Sullivan-Patrick just signed our Contributor License Agreement. 👍 Always at your service, clabot |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Sullivan-Patrick . The new tests you've added validate that the names ROWPARTITION
and ROWOFFSET
may be used as output column aliases, but we also need tests validating that they can be used in source schemas as well.
Also, I think it's fine to just have a single test covering the use of both aliases (minor optimization in order to reduce the number of new tests being added, since we don't expect the behavior for the two aliases to be different).
It might also be interesting to add a test where the new columns have the same data types as the pseudocolumns that will be added as part of KLIP-50.
I've also updated the PR title to reflect that this is a test-only change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Sullivan-Patrick thanks for the updates. It looks like we're still missing tests for source columns named ROWPARTITION/ROWOFFSET, though. Both tests are currently testing the use of those names as output column aliases only.
} | ||
}, | ||
{ | ||
"name": "test ROWOFFSET and ROWPARTITION user columns with data types the pseudocolumns will later represent", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't want to have to change the test name once KLIP-50 is implemented (we'd have to remember to rename the historic plan files if so).
"name": "test ROWOFFSET and ROWPARTITION user columns with data types the pseudocolumns will later represent", | |
"name": "test ROWOFFSET and ROWPARTITION user columns with pseudocolumn data types", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Woops, I totally missed the source schema thing the first time around. Hopefully the latest commits address everything.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Sullivan-Patrick -- LGTM!
Description
Adds testing to ensure
ROWOFFSET
andROWPARTITION
can freely be used as user columns before KLIP-50 is integrated.Testing done
Individual tests for
ROWOFFSET
andROWPARTITION
Reviewer checklist